New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to choose which character to use to replace invalid characters #37

Open

garoxas opened this issue Nov 10, 2020 · 0 comments

garoxas commented Nov 10, 2020

On versions pre-1.0.0 invalid characters are replaced by -, however in newer versions it's now using _

Implementation in download.js below

  const native = async (options, callback) => {
    options.filename = options.filename
      .replace(/[`~!@#$%^&*()|+=?;:'",<>{}[\]\\/]/gi, '_')
      .replace(/[\\/:*?"<>|]/g, '_')
      .substring(0, 240);

I would like to propose that users can choose which character they want to use in the option menu as personally I prefer using -

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment