From 82dd5f1ac56bc71876839c744af542c277839e44 Mon Sep 17 00:00:00 2001 From: josmas Date: Thu, 11 Feb 2021 22:16:49 +0000 Subject: [PATCH 1/2] display failedReason in cases in which there is no stacktrace --- src/ui/hooks/useDetailsTabs.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/ui/hooks/useDetailsTabs.tsx b/src/ui/hooks/useDetailsTabs.tsx index 454cb359..d072499b 100644 --- a/src/ui/hooks/useDetailsTabs.tsx +++ b/src/ui/hooks/useDetailsTabs.tsx @@ -47,6 +47,9 @@ export function useDetailsTabs(currentStatus: Status) { return ( <> {!failedReason &&
{'NA'}
} + {stacktrace && stacktrace.length === 0 && ( +
{failedReason}
+ )} {stacktrace} From 3f37d3a4d24c4476186496b5cf5b487c0e8f1abe Mon Sep 17 00:00:00 2001 From: josmas Date: Fri, 12 Feb 2021 14:30:57 +0000 Subject: [PATCH 2/2] change display loging in response to review --- src/ui/hooks/useDetailsTabs.tsx | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/ui/hooks/useDetailsTabs.tsx b/src/ui/hooks/useDetailsTabs.tsx index d072499b..bab5b483 100644 --- a/src/ui/hooks/useDetailsTabs.tsx +++ b/src/ui/hooks/useDetailsTabs.tsx @@ -46,13 +46,15 @@ export function useDetailsTabs(currentStatus: Status) { case 'Error': return ( <> - {!failedReason &&
{'NA'}
} - {stacktrace && stacktrace.length === 0 && ( -
{failedReason}
+ {stacktrace?.length === 0 ? ( +
+ {!!failedReason ? failedReason : 'NA'} +
+ ) : ( + + {stacktrace} + )} - - {stacktrace} - ) default: