Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the behavior of attemptsMade configurable. #562

Closed
coder-pm opened this issue Apr 26, 2023 · 8 comments
Closed

Make the behavior of attemptsMade configurable. #562

coder-pm opened this issue Apr 26, 2023 · 8 comments

Comments

@coder-pm
Copy link

coder-pm commented Apr 26, 2023

The behavior of attemptsMade is different for bull and bullmq. I'm using the latest versions of bullmq and bull-board, and it shows attempt #2 for the first run.

Source: taskforcesh/bullmq#1002

@felixmosh
Copy link
Owner

Weird, I'm using bullmq as well, I haven't saw this behaviour.

Can you make a reproduction repo?

@coder-pm
Copy link
Author

I am actually using the pro version - @taskforcesh/bullmq-pro.

@felixmosh
Copy link
Owner

It doesn't matter pro or not, it is in the base...

Let me check this.

For meanwhile can you make sure that for some season your job not runs twice? (Console.log inside a worker will do that)

@coder-pm
Copy link
Author

image

It's 1 from the very beginning.

My libs:
"bullmq": "3.11.0"
"@taskforcesh/bullmq-pro": "^5.2.2"
"@bull-board/express": "^5.1.1"

@felixmosh
Copy link
Owner

I've checked the code, and seems that we've aligned it already in #386

The UI expects attempsMade to start from 1 (as it is in bullMQ).

So, I'm not sure what is the problem in your case.
If you will be able to share a repo that reproduces this, it will help me to investigate this issue.

@coder-pm
Copy link
Author

I'll try to debug those places tomorrow and let you know.

@coder-pm
Copy link
Author

image

It is incremented in the getJobs method.

image

@coder-pm
Copy link
Author

Problem solved: #322 (comment)

Was using wrong adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants