Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related approach just FYI #10

Closed
mikelnrd opened this issue Sep 29, 2019 · 2 comments
Closed

Related approach just FYI #10

mikelnrd opened this issue Sep 29, 2019 · 2 comments

Comments

@mikelnrd
Copy link

Hi

This looks very similar in approach, just thought I'd share it with you in case it's of interest:

https://github.com/prometheus/client_golang/blob/master/prometheus/promhttp/delegator.go

Source:
I came across httpsnoop in this thread which might also be of interest if you haven't seen it:
golang/go#18997 (comment)

@felixge
Copy link
Owner

felixge commented Nov 2, 2019

https://github.com/prometheus/client_golang/blob/master/prometheus/promhttp/delegator.go

The prometheus implementation didn't exist when I wrote this library. I wonder if they were aware of my implementation and decided against using it. But it seems like this wasn't the case.

golang/go#18997 (comment)

I agree with this thread. Having to do this kind of hacking like my lib is terrible, it'd be nice if there were better solutions!

@felixge
Copy link
Owner

felixge commented Sep 19, 2020

Closing this since there is no more action to be taken.

@felixge felixge closed this as completed Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants