Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hell broke loose after update to 1.4.1 #127

Closed
ADmad opened this issue Jun 17, 2017 · 11 comments
Closed

Hell broke loose after update to 1.4.1 #127

ADmad opened this issue Jun 17, 2017 · 11 comments

Comments

@ADmad
Copy link

ADmad commented Jun 17, 2017

Sorry for the hyperbole in the title but since the release of 1.4 series of the extension which uses v4.5 of the language server, the language server constantly keeps crashing. IMHO it was premature to do stable release of this extension which uses the new language parser. I will submit issues on the language server repo soon to help fix the issues but I suggest making stable versions of this extension use the old language parser until the new one has gone through some more real world testing. Separate beta series could be started for trying out the new parser.

@ADmad
Copy link
Author

ADmad commented Jun 17, 2017

VSCode 1.13 auto updates extensions which makes matters worse.

@jens1o
Copy link
Contributor

jens1o commented Jun 17, 2017

You can disable auto update at the upper right-hand corner in the extensions viewlet.

@ADmad
Copy link
Author

ADmad commented Jun 17, 2017

You can disable auto update at the upper right-hand corner in the extensions viewlet.

Yes I can, but that's not the point. "Stable" releases of this extension should not be using the new parser until it has some more testing.

@jens1o
Copy link
Contributor

jens1o commented Jun 17, 2017

I tested it for over 2 weeks and I didn't found any bugs once the switch was done, I'm curious I forgot so many, because I thought it's quite stable... Could you report them as soon as possible so this won't affect others even longer, please?

@ADmad
Copy link
Author

ADmad commented Jun 17, 2017

I am sure you did your best but just one or two individuals testing such a complex tool is not sufficient :) I will try to submit issues ASAP.

Btw how can I revert to an older version of the extension?

@felixfbecker
Copy link
Owner

@ADmad There is a vsix for 1.3.0 on the releases page: https://github.com/felixfbecker/vscode-php-intellisense/releases/tag/v1.3.0
Sorry for the inconvenience, please open all the issues you see at the language server repo

@felixfbecker
Copy link
Owner

Sorry, I made a mistake when building the vsix (only added automatic vsix release very recently). Should be fixed now.

@ADmad
Copy link
Author

ADmad commented Jun 17, 2017

No worries, thanks.

@ADmad
Copy link
Author

ADmad commented Jun 18, 2017

@ADmad ADmad closed this as completed Jun 18, 2017
@jens1o
Copy link
Contributor

jens1o commented Jun 18, 2017

Happy to hear that! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants