Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible useful features from Roave/BetterReflection #223

Closed
MarkRedeman opened this issue Dec 22, 2016 · 2 comments
Closed

Possible useful features from Roave/BetterReflection #223

MarkRedeman opened this issue Dec 22, 2016 · 2 comments

Comments

@MarkRedeman
Copy link

Hi Felix,

Are you aware of the Roave/BetterReflection library? They may have some features that could be useful for your project.
For instance there is currently a pr to add a variable collector which adds the option to get all variables (and their possible types) inside of function.
This might help resolve #160 (though I'm not sure since I haven't yet looked at your code).

@felixfbecker
Copy link
Owner

No, wasn't aware of it. Does it resolve types recursively like I do?
I'm always for using existing packages and improving them.
#160 is a very easy ticket though, I just haven't got around to fixing it, it's low priority.

@MarkRedeman
Copy link
Author

No, wasn't aware of it. Does it resolve types recursively like I do?

I'm not quite sure yet how you do it (I might take a look at your code during my christmas break while I try to integrate this into my Emacs setup :) ). The PR that I mentioned currently only supports assigning variable definitions and determines its type by the right hand side of the assignment.

I'm always for using existing packages and improving them.
#160 is a very easy ticket though, I just haven't got around to fixing it, it's low priority.

Good, I will close this issue for now since it isn't a bug or feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants