Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(flutter_login): use emit.onEach in AuthenticationBloc #4211

Merged
merged 6 commits into from
Jul 28, 2024
Merged

refactor(flutter_login): use emit.onEach in AuthenticationBloc #4211

merged 6 commits into from
Jul 28, 2024

Conversation

LukasMirbt
Copy link
Contributor

Status

READY

Breaking Changes

NO

Description

  • Uses emit.onEach instead of handling authentication status stream subscription manually.
  • Renames AuthenticationLogoutRequested to AuthenticationLogoutPressed to align more with the user action.
  • Breaks out duplicated blocTest build methods to a shared buildBloc method to follow the pattern used in other Bloc examples.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel
Copy link
Owner

Thanks for the PR! I'll take a closer look this weekend but also note we'll likely need to update the accompanying tutorial.

@felangel felangel added example Example application refactor Refactor an existing implementation labels Jul 26, 2024
@LukasMirbt
Copy link
Contributor Author

Cool!
I updated the tutorial now as well. Let me know what you think!

felangel
felangel approved these changes Jul 28, 2024
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks so much for the contributions! 💙

@felangel felangel changed the title refactor(flutter_login): use emit.onEach instead of handling stream subscription manually refactor(flutter_login): use emit.onEach in AuthenticationBloc Jul 28, 2024
@felangel felangel merged commit f82f896 into felangel:master Jul 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@LukasMirbt LukasMirbt

Labels
example Example application refactor Refactor an existing implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasMirbt @felangel