This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
add OIDC support #136
Open
add OIDC support #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the vagrant setup to Fedora 35. Signed-off-by: Ryan Lerch <[email protected]>
Signed-off-by: Ryan Lerch <[email protected]>
Signed-off-by: Ryan Lerch <[email protected]>
Signed-off-by: Ryan Lerch <[email protected]>
|
note that there is another WIP PR for this: but didnt base this work off that at all -- wasn't sure about how it was working. |
|
Looks great to me! I was working on a similar patch to update for use at Rocky Linux. One thing that I was thinking was to parameterize the 'signed_fpca' part in the group, so it can be set to different values depending on the configuration. (E.g., we are using a different group name in Rocky's account system because we don't have the fpca, of course). Thank you very much for this patch. I'm very glad I found it before getting too far into mine! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THe first 3 commits are a little bit of cleanup (vagrant dev updates, and supporting only python3)
The 4th commit does the actual work of updating nuancier to use OIDC.
Resolves: #130