This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
[WIP] Update to oidc working #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove broken link to image that was at .. image:: http://shieldkins.elrod.me/fedora/nuancier
Add git to things to install
Change yum to dnf
Change yum to dnf, however not clear which system wide repositories nuancier is in.
Update manual install directions
improve formatting
formatting fixes, update information on requirements
Co-Authored-By: Clement Verna <[email protected]>
Update development.rst Change yum to dnf Update deployment.rst Change yum to dnf, however not clear which system wide repositories nuancier is in. Update README.rst Update manual install directions Update README.rst improve formatting Update README.rst formatting fixes, update information on requirements Update README.rst Co-Authored-By: Clement Verna <[email protected]>
Use Fedora 30 image instead of Fedora 25
Use Python3 Update to use loop syntax
Remove , sshfs_opts_append: "-o nonempty" since the nonempty option is no longer available.
Use Python3 in Vagrant example file
Change print statement to be compatible with Python 3
Fedora messaging is using Twisted and this is supported by python 3.5 or newer.
Signed-off-by: Sebastian Wojciechowski <[email protected]>
Before, function edit_election emited message with information about changed "Election year", "Number of votes possible" and "Number of candidates per user" even though those values hasn't changed. The reason was that we compared different types(string with intiger) because the form "add\edit election" saved mentioned values as text instead of integers. This commit corrects this. Signed-off-by: Sebastian Wojciechowski <[email protected]>
Signed-off-by: Sebastian Wojciechowski <[email protected]>
Signed-off-by: Sebastian Wojciechowski <[email protected]>
update werkzeug library to invoke required workzeug.utils
… seems to cover everything rpm-python was doing
…_nuancier_to_fedora-messaging
…uancier_to_fedora-messaging
|
Also useful information: this was built on top of the changes from PR #127 |
|
@jontrossbach are you still working on this? there seems to be a lot of commits in here that arent part of this PR (or #127 for that matter) -- i got a little confused trying to figure this out. also, FYI we now have https://github.com/fedora-infra/tiny-stage which you can use if you want instead of iddev |
|
I'm not actively working on this... if I get time I will circle back as soon as possible, though. tinystage sounds like exactly what I need for both this and to verify another patch. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
A while back I updated nuancier and tried to test it. If I remember correctly login it is working with FAS but logout was sort of funny. I just wanted to update this here in case anyone can try and improve upon or learn from it.
At this point I'm not sure if the problem rests in my changes or some permissions set up in ipsilon. I got stalled on this a while back and was never able to circle back to it.
From my discussions with @puiterwijk and @pypingou I was able to log into a local instance of nuancier using oidc auth processing but unfortunately the application wasn't acting as expected once I logged in. For instance, I wasn't able to logout and I wasn't able to create an election. I also did not use Patrick's suggestion about using a double oidc_callback directory path. I wasn't able to verify for a second time that Patrick's suggestion wasn't working (because I am stuck logged into ipsilon) but, for me, the first time I tried Patrick's suggestion it didn't work and wouldn't let me login.
My process for being able to log in was using my vagrant machine's local IP address instead of localhost and creating my client secrets based on that; I also added ssl verification using flask adhoc mode (ingredients for my set up are below):
oidc-register https://iddev.fedorainfracloud.org/ https://192.168.122.36:5000
https://github.com/jontrossbach/nuancier/tree/update-to-oidc-vm
It is possble that their is a groups issue going on with the account I was used (my own stand issue FAS account). I hope this becomes useful to someone at some point, I was hoping to roll though a few of these apps and update them to OIDC but had got stuck here.