Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant function get_cat #230

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Dec 21, 2023

Closes #96 by replacing get_cat with a call to apass_dr9.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a222f49) 53.66% compared to head (d35a332) 53.80%.
Report is 1 commits behind head on main.

Files Patch % Lines
stellarphot/utils/magnitude_transforms.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   53.66%   53.80%   +0.13%     
==========================================
  Files          23       23              
  Lines        2890     2881       -9     
==========================================
- Hits         1551     1550       -1     
+ Misses       1339     1331       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwcraig mwcraig merged commit 9301a69 into feder-observatory:main Dec 21, 2023
9 checks passed
@mwcraig mwcraig deleted the remove-get-cat branch February 8, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_cat function replacement
2 participants