Update photutils and fix a couple broken tests #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanCab
approved these changes
Oct 17, 2023
| @@ -245,9 +245,9 @@ def test_photometry_data(): | |||
| assert phot_data.camera.read_noise == 10.0 * u.electron | |||
| assert phot_data.camera.dark_current == 0.01 * u.electron / u.second | |||
| assert phot_data.camera.pixel_scale == 0.563 * u.arcsec / u.pix | |||
| assert phot_data.observatory.lat.value == 46.86678 | |||
| np.testing.assert_almost_equal(phot_data.observatory.lat.value, 46.86678) | |||
There was a problem hiding this comment.
Cool, nice to know this function exists for checking floats. Looked over the document, seems to be used fine here (I was concerned about precision, but default precision is 7 decimal places, which is clearly enough here).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty straightforward one. The original motivation was to simply update the minimum photutils so taht we can, down the road, pull in some features from it, but I noticed a couple floating point tests were failing locally so I fixed those too.