Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check off some of the minor items on Scientific Python review #198

Closed
4 of 6 tasks
mwcraig opened this issue Dec 10, 2023 · 0 comments · Fixed by #199
Closed
4 of 6 tasks

Check off some of the minor items on Scientific Python review #198

mwcraig opened this issue Dec 10, 2023 · 0 comments · Fixed by #199
Assignees
Labels
refactor Summer 2023 project to rewrite stellarphot

Comments

@mwcraig
Copy link
Contributor

mwcraig commented Dec 10, 2023

Let's do these items from this review:

  • VPP001: `Validate pyproject.toml Invalid pyproject.toml! Error: project.license must be valid exactly by one definition
  • PY005: Has tests folder. Projects must have a folder called test or src/*/test -- not sure why this is failing -- couldn't figure out why this passes for astropy but not for stellarphot since the structure is the same -- See Consider changing location of test directory #200 instead.
  • PP308: Specifies useful pytest summary
  • PP309: Filter warnings specified filterwarnings must be set (probably to at least ["error"]). Python will hide important warnings otherwise, like deprecations. -- skip for now as this means fixing all warnings
  • GH200: Maintained by Dependabot -- add a dependabot.yml to update actions automatically.
  • GH102: Auto-cancel on repeated PRs. At least one workflow should auto-cancel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Summer 2023 project to rewrite stellarphot
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant