Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New base class that is Table plus header/attributes #114

Closed
mwcraig opened this issue Jun 29, 2023 · 1 comment · Fixed by #125
Closed

New base class that is Table plus header/attributes #114

mwcraig opened this issue Jun 29, 2023 · 1 comment · Fixed by #125
Assignees
@JuanCab
Labels
New base/data classes Develop a base class for the new `astropy.table.Table`+headers class refactor Summer 2023 project to rewrite stellarphot
Milestone
2.0.0 -- alpha

Comments

@mwcraig
Copy link
Contributor

mwcraig commented Jun 29, 2023 •
edited
Loading

The base class should:

  • Enforce names that are common to derived from classes
    • Unique object ID
    • ra
    • dec
  • Do not add ability to add columns as attributes for now
@mwcraig mwcraig added the New base/data classes Develop a base class for the new `astropy.table.Table`+headers class label Jun 29, 2023
@mwcraig mwcraig added refactor Summer 2023 project to rewrite stellarphot and removed refactor Summer 2023 project to rewrite stellarphot labels Jun 29, 2023
@mwcraig mwcraig added this to the Reimplemented data structure milestone Jun 29, 2023
@mwcraig mwcraig added the refactor Summer 2023 project to rewrite stellarphot label Jun 29, 2023
@JuanCab JuanCab mentioned this issue Jun 30, 2023
Merged
@JuanCab
Copy link
Contributor

JuanCab commented Jun 30, 2023

A first stab has been made in PR #125.

@mwcraig mwcraig moved this from 🆕 New to 🏗 In progress in stellarphot refactoring Jun 30, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in stellarphot refactoring Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanCab JuanCab

Labels
New base/data classes Develop a base class for the new `astropy.table.Table`+headers class refactor Summer 2023 project to rewrite stellarphot
Projects
stellarphot refactoring
Status: ✅ Done
Milestone
2.0.0 -- alpha
Development

Successfully merging a pull request may close this issue.

Initial version of BaseEnhancedTable and PhotometryData added JuanCab/stellarphot
2 participants
@mwcraig @JuanCab