Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/6009 add case tests #6026

Open
wants to merge 1 commit into
base: release/public-20241112
Choose a base branch
from
Open

Feature/6009 add case tests #6026

wants to merge 1 commit into from
+2,418 −0

Conversation

tmpayton
Copy link
Contributor

@tmpayton tmpayton commented Oct 23, 2024 •
edited
Loading

Summary (required)

This ticket adds integration testing with Elasticsearch to test all case filters. I will make separate PRs for AOs, statutes, and the other legal endpoints.

Required reviewers 2 - 3 backend developers

Impacted areas of the application

General components of the application that this PR will affect:

  • circleci pipeline
  • pytest

How to test

  • checkout this branch
  • start elasticsearch in new terminal
  • run pytest in another terminal
  • to see output from any individual test uncomment the logging statements and run pytest tests/integration/test_cases_elasticsearch.py -s

Note: running locally will clear out your elasticsearch environment

@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (8b93795) to head (0130fb8).

Additional details and impacted files 
@@                     Coverage Diff                     @@
##           release/public-20241112    #6026      +/-   ##
===========================================================
+ Coverage                    86.59%   87.85%   +1.25%     
===========================================================
  Files                           82       82              
  Lines                         9080     9080              
===========================================================
+ Hits                          7863     7977     +114     
+ Misses                        1217     1103     -114

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmpayton tmpayton changed the title [WIP] Feature/6009 add case tests Feature/6009 add case tests Oct 28, 2024
@tmpayton tmpayton force-pushed the feature/6009-add-case-tests branch 3 times, most recently from a691cd9 to ca851ae Compare October 28, 2024 18:09
@fec-jli
Copy link
Contributor

fec-jli commented Nov 1, 2024

Great work !!!
1)We need to update the README file to include instructions for testing the Elasticsearch part locally. such as: start Elasticsearch server locally before run pytest
2)change file name legal_test_data.py to test_legal_data.py (naming convention)

@tmpayton
Copy link
Contributor Author

tmpayton commented Nov 4, 2024

Great work !!! 1)We need to update the README file to include instructions for testing the Elasticsearch part locally. such as: start Elasticsearch server locally before run pytest 2)change file name legal_test_data.py to test_legal_data.py (naming convention)

Thank you for the review @fec-jli, I made the changes you requested!

@tmpayton tmpayton force-pushed the feature/6009-add-case-tests branch 2 times, most recently from 9b61d74 to c6ca39f Compare November 6, 2024 13:31
@tmpayton tmpayton changed the base branch from develop to release/public-20241112 November 6, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkfec pkfec Awaiting requested review from pkfec

@fec-jli fec-jli Awaiting requested review from fec-jli

@cnlucas cnlucas Awaiting requested review from cnlucas

Assignees
No one assigned
Labels
Please review
Projects
Website project
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add case document tests to legal/search endpoint
2 participants
@tmpayton @fec-jli