Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Totals for John Delaney incorrect on election profile page(/elections/) #3611

Closed
2 tasks done
lbeaufort opened this issue Mar 8, 2019 · 6 comments · Fixed by #3647
Closed
2 tasks done

Totals for John Delaney incorrect on election profile page(/elections/) #3611

lbeaufort opened this issue Mar 8, 2019 · 6 comments · Fixed by #3647

Comments

@lbeaufort
Copy link
Member

lbeaufort commented Mar 8, 2019

Checking: P00006213, DELANEY, JOHN K.

datatable_url
https://api.open.fec.gov/v1/candidates/totals/?candidate_id=P00006213&election_year=2020&full_election=true&api_key=DEMO_KEY&sort=-receipts

candidate_profile_url
https://api.open.fec.gov/v1/candidate/P00006213/totals/?cycle=2020&full_election=true&api_key=DEMO_KEY

election_profile_url
https://api.open.fec.gov/v1/elections/?candidate_id=P00006213&cycle=2020&election_full=true&api_key=DEMO_KEY&office=president&sort_nulls_last=true&sort=-total_receipts&per_page=100

!!! ERROR - results don't match!!!
Candidate datatable: 6145779.44
Candidate profile page: 6145779.44
Election profile page: 5874365.79

!!! ERROR - results don't match!!!
Candidate datatable: 5899574.2
Candidate profile page: 5899574.2
Election profile page: 5660142.67

May become a bigger problem as more people start to/continue to report going into 2020. Affects candidates (likely high profile candidates) who convert their committees.

Completion criteria:

  • Look at how the totals are calculated for the /totals/ endpoint
  • For Presidential candidates, make sure totals are including information from form 3 and 3P
@PaulClark2
Copy link
Contributor

PaulClark2 commented Mar 12, 2019

Correct:
Includes both F3 and F3P financial data (candidate converted his House committee to his presidential committee)
datatable_url
https://api.open.fec.gov/v1/candidates/totals/?candidate_id=P00006213&election_year=2020&full_election=true&api_key=3WFCX5yqR4ZQmRKkQemdZVKEebxwWHQ6MPVc40l9&sort=-receipts

candidate_profile_url
https://api.open.fec.gov/v1/candidate/P00006213/totals/?cycle=2020&full_election=true&api_key=3WFCX5yqR4ZQmRKkQemdZVKEebxwWHQ6MPVc40l9

Candidate profile page: https://www.fec.gov/data/candidate/P00006213/
total receipts $6,145,779.44; total disbursements $5,899,574.20

Incorrect:
seems to include only F3P financial data

election_profile_url
https://api.open.fec.gov/v1/elections/?candidate_id=P00006213&cycle=2020&election_full=true&api_key=3WFCX5yqR4ZQmRKkQemdZVKEebxwWHQ6MPVc40l9&office=president&sort_nulls_last=true&sort=-total_receipts&per_page=100

Election profile page: https://www.fec.gov/data/elections/president/2020/
total receipts $5,874,365.79; total disbursements $5,660,142.67

FORM_TP_CD RPT_YR RPT_TP TTL_RECEIPTS TTL_DISB
F3 C00508416 Q1 $83,825.05 $40,469.30
F3 C00508416 Q2 $187,588.60 $198,962.23
F3P C00508416 Q3 $577,085.53 $318,036.53
F3P C00508416 YE $647,299.54 $580,931.31
F3P C00508416 Q1 $2,173,151.75 $1,722,890.44
F3P C00508416 Q2 $240,167.48 $915,614.48
F3P C00508416 Q3 $1,088,448.44 $1,164,848.39
F3P C00508416 YE $1,148,213.05 $957,821.52
. TTL_RECEIPTS TTL_DISB
Total $6,145,779.44 $5,899,574.20
F3 only $271,413.65 $239,431.53
F3P only $5,874,365.79 $5,660,142.67

It looks like the election profile endpoint/page is excluding F3 data that it shouldn't. @lbeaufort would @hcaofec 's F3/F3P/F3X table help here? @hcaofec what's the status of that combined table?

@lbeaufort
Copy link
Member Author

@PaulClark2 I also found that the candidate data table has the wrong COH for Delaney. I'm thinking this should be a separate issue because it's a different endpoint that appears to be correct.

!!! ERROR - COH results don't match!!!
Candidate datatable: $536,496.16
Candidate profile page: $268,248.08
Election profile page: $268,248.08

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented Mar 19, 2019

^^ The above (comment) work was moved to a separate ticket here: #3635

@hcaofec
Copy link
Contributor

hcaofec commented Mar 21, 2019

Here is another example because F3 was filed. FULLER, REV VERONICA RONNIE, P00006684

receipts:
Candidate datatable: 749
Candidate profile page: 749
Election profile page: 0

disbursements:
!!! ERROR - results don't match!!!
Candidate datatable: 549
Candidate profile page: 549
Election profile page: 0

@hcaofec
Copy link
Contributor

hcaofec commented Mar 21, 2019

Another example: S0KS00190 , ADAMS, ELLIOTT, cand_election_year = 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants