Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOs: Short-term fix for AO missed/false positive citations #3461

Closed
2 tasks done
lbeaufort opened this issue Oct 25, 2018 · 3 comments
Closed
2 tasks done

AOs: Short-term fix for AO missed/false positive citations #3461

lbeaufort opened this issue Oct 25, 2018 · 3 comments
Assignees
Milestone

Comments

@lbeaufort
Copy link
Member

lbeaufort commented Oct 25, 2018

What we're after:
So that we can quickly update AO citations that are missed or accidentally included by the AO loading process, we should have a list-like thing with "extra" citations that aren't picked up by the REGEX due to bad OCR text or unusual formats.

  • Design python data structure(s) lookup to hold this info - maybe AO #, citation, date added, added by, exclude/include ....anything else relevant. (Separate include/exclude lookup?)
  • Modify the AO reload management task to also check this lookup for citations missed excluded ( 1 - remove false positives 2 - add missed)

See #3393 as an example

See also, past research on false positives:
https://docs.google.com/spreadsheets/d/1-nf-oAPtw3LisZInuDHcQ7JdpyEQXRISZ4kY1ONrFcE/edit?usp=drive_web&ouid=114351900669501389307

https://docs.google.com/spreadsheets/d/161cnTtYzXzXW2iNxZPIX9rYhko2ZV2deHYFNDP-R49o/edit#gid=0

For a more elegant long-term solution, see #3302

@patphongs
Copy link
Member

@lbeaufort This looks like a really big issue. Can we split it up? Should we split up the python data structure design and the modification of the AO reload management?

Is this something that we want to take out of next sprint 7.5? Seems like a lot, maybe we want to save this for the innovation sprint? @AmyKort

@AmyKort
Copy link

AmyKort commented Oct 26, 2018

Can we make that decision at sprint planning? I'm fine either way, but I'd like to see how the work breaks down for this upcoming sprint.

@lbeaufort
Copy link
Member Author

This is now a small task, sorry if I made it sound complicated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants