Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor elections (ElectionView) endpoint to extend ApiResource #3254

Closed
fec-jli opened this issue Jun 29, 2018 · 6 comments
Closed

Refactor elections (ElectionView) endpoint to extend ApiResource #3254

fec-jli opened this issue Jun 29, 2018 · 6 comments
Assignees
@fec-jli
Labels
Work: Back-end
Milestone
Sprint 6.4

Comments

@fec-jli
Copy link
Contributor

fec-jli commented Jun 29, 2018

this issue related with Issue fecgov/fec-cms#2010
to enable the export link in election summery page.
@fec-jli fec-jli added this to the Sprint 6.3 milestone Jun 29, 2018
@PaulClark2
Copy link
Contributor

Is this a refactor or are we adding export functionality?

@fec-jli
Copy link
Contributor Author

fec-jli commented Jun 29, 2018

in order to make export work, we need refactor this endpoint first.

This was referenced Jun 29, 2018
Closed
Closed
@PaulClark2
Copy link
Contributor

PaulClark2 commented Jun 29, 2018 •
edited
Loading

So the refactor work would allow us to enable downloads for individual contributions to candidates by size and individual contributions to candidates by state? The other data tables on the page already have functional export buttons.

  • individual contributions to candidates by size
  • individual contributions to candidates by state

#3253 takes care of the download for candidate financial totals, correct?

@PaulClark2 PaulClark2 modified the milestones: Sprint 6.3, Sprint 6.4 Jun 29, 2018
@fec-jli
Copy link
Contributor Author

fec-jli commented Jun 29, 2018 •
edited
Loading

yes, #3253 only takes care of the download for candidate financial totals.
the reason I am working on this, because the code to fix this #3221 are mixed in same python file.
we better to do together. for other two export individual contributions links, we can leave this for the future.

@PaulClark2
Copy link
Contributor

related to fecgov/fec-cms#2153

@PaulClark2 PaulClark2 mentioned this issue Jul 3, 2018
Closed
1 task
@AmyKort AmyKort mentioned this issue Jul 16, 2018
Closed
2 tasks
@fec-jli fec-jli mentioned this issue Jul 19, 2018
Merged
@JonellaCulmer
Copy link
Contributor

Work has been merged, so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fec-jli fec-jli

Labels
Work: Back-end
Projects
None yet
Milestone
Sprint 6.4
Development

No branches or pull requests
5 participants
@vrajmohan @PaulClark2 @fec-jli @lbeaufort @JonellaCulmer