Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AO and MUR schema creation for tests #2835

Closed
vrajmohan opened this issue Dec 22, 2017 · 3 comments
Closed

Refactor AO and MUR schema creation for tests #2835

vrajmohan opened this issue Dec 22, 2017 · 3 comments
Assignees
@vrajmohan
Labels
Technical debt
Milestone
Sprint 7.1

Comments

@vrajmohan
Copy link
Contributor

https://github.com/18F/openFEC/blob/develop/data/load_advisory_opinions_schema.sql and https://github.com/18F/openFEC/blob/develop/data/load_murs_schema.sql were used to create schemas for legal docs "integration" tests. Now that the entire DB schema is being created with flyway and the schema for MURs and AOs is already included in data/migration/*, we can remove these files and use the flyway generated schema.
@lbeaufort
Copy link
Member

Planning to address this in PI 6

@vrajmohan vrajmohan self-assigned this May 23, 2018
@vrajmohan
Copy link
Contributor Author

I have started work on this and this should be easy to complete.

@vrajmohan vrajmohan reopened this Jun 14, 2018
@lbeaufort lbeaufort modified the milestone: Sprint 7.1 Aug 31, 2018
@vrajmohan vrajmohan added this to the Sprint 7.1 milestone Sep 10, 2018
@vrajmohan
Copy link
Contributor Author

Completed.

@patphongs patphongs mentioned this issue Feb 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrajmohan vrajmohan

Labels
Technical debt
Projects
None yet
Milestone
Sprint 7.1
Development

No branches or pull requests
4 participants
@ccostino @vrajmohan @PaulClark2 @lbeaufort