Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Election data fixes #2590

Closed
6 of 7 tasks
noahmanger opened this issue Aug 7, 2017 · 5 comments
Closed
6 of 7 tasks

Election data fixes #2590

noahmanger opened this issue Aug 7, 2017 · 5 comments
Milestone

Comments

@noahmanger
Copy link

noahmanger commented Aug 7, 2017

Here's a fresh issue with the things that need to be fixed with elections dates and data (consolidating https://github.com/18F/openFEC/issues/2544 , fecgov/openFEC-web-app#2227, https://github.com/18F/openFEC/issues/2428:

@jontours
Copy link
Contributor

jontours commented Aug 9, 2017

Recording this before I forget; the issue with the Texas candidates has nothing to do with the election endpoints. I'll try to get it knocked it out with the PR but it may be a straggler.

@jontours
Copy link
Contributor

Colorado issue is fixed with latest PR. I verified my work with open source information about that election (which was probably sourced from the FEC). I'm showing 5 candidates for 2018 CO 6th.
4 Democrats and 1 Republican (the incumbent).

@jontours
Copy link
Contributor

jontours commented Aug 14, 2017

And finally the issue with Texas candidates done now as well, turns out it was related to some of the other problems (but was on a unique endpoint). And as @PaulClark2 mentioned we were using the wrong column for the cycle filter.

@jontours
Copy link
Contributor

jontours commented Aug 14, 2017

After looking at the code, think the issue with Texas may not have been a problem after all, I think the front-end just needs to pass in election_full=true. I'm not sure though, maybe have to talk about that one @noahmanger @LindsayYoung.

@LindsayYoung
Copy link
Contributor

Moving the TX case to its own issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants