Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate off dimcmteproperties #2049

Closed
LindsayYoung opened this issue Nov 22, 2016 · 5 comments
Closed

Migrate off dimcmteproperties #2049

LindsayYoung opened this issue Nov 22, 2016 · 5 comments

Comments

@LindsayYoung
Copy link
Contributor

LindsayYoung commented Nov 22, 2016

Warehouse Postgres
dimcmteproperties disclosure.fec_vsum_f1

This might be the tricky one to make sure we have the same fields

"We're also still using dimcmteproperties, since I didn't see another place to get treasurer name and address, custodian name and address, fax number, leadership pac, lobbyist registrant pac flag, and party committee type. Are those fields available in FECP? Or can we drop them?"
see full conversation: https://github.com/18F/openFEC/issues/1327

@noahmanger noahmanger changed the title migrate off dimcmteproperties Migrate off dimcmteproperties Nov 22, 2016
@noahmanger noahmanger added this to the Sprint 1 milestone Nov 22, 2016
@jontours
Copy link
Contributor

The only table in the database that contains these fields in the database is disclosure.nml_form_1. @PaulClark2 @jwchumley It seems that replacing dimcmteproperties with fec_vsum_f1 is a valid mapping to support migrating off that data warehouse table. Can this please be confirmed? Thanks.

@PaulClark2
Copy link
Contributor

Yes, that should work.

fec_vsum_f1 will not include information from nml_form_1z

@jwchumley can you think of another way to replace dimcmteproperties?

@jontours jontours self-assigned this Nov 30, 2016
@jontours
Copy link
Contributor

jontours commented Dec 1, 2016

@PaulClark2 We are about to merge this into the release and forgot about the column expire_date in dimcmteproperties, is that column deprecated? Is it important to still have?

@PaulClark2
Copy link
Contributor

I don't think it's important. We can determine the valid date range for a Form 1 based on it's receipt date and the receipt date of the F1 that amends (if it's amended).

@jontours
Copy link
Contributor

jontours commented Dec 3, 2016

Thanks @PaulClark2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants