[User feedback] Optional phone number preventing save #2424
Comments
|
gregg.moreland commented: [~accountid:5b93ddba73130a2b8c662e23] Do you know which transaction? Was the user trying to create a new contact for that transaction? |
|
gregg.moreland commented: [~accountid:5b93ddba73130a2b8c662e23] I have tried creating several transactions, adding contacts of all types (individual, committee, organization, candidate) and left the phone number blank on all. I have not been able to recreate, so I need more details. Thanks |
|
gregg.moreland commented: I think I figured this out. If you click/tab into the Telephone field when adding a contact, the field is flagged as an error, even though you haven’t entered anything. [~accountid:712020:169a1b29-e3ab-43ca-a22d-7d6f230207bd] Here is another one to looke at. This is if you add a contact both from a transaction but also from Manage Contacts. Tab or click into the Optional Telephone field, and tab/click out of it without entering anything, the error message will display and the contact/transaction cannot be saved due to this error. |
|
Shelly Wise commented: QA retested and verified this issue as a Bug on both STAGE/DEV. This bug can be found in several areas, Create Contact page, Edit Contact page, add new contact to a transaction. Below are steps showing “Edit Contact”. How to replicate the issue: Select a Contact on the Manage contacts page to edit.!image-20241205-160806.png|width=1335,height=398,alt="image-20241205-160806.png"! The “TELEPHONE (OPTIONAL)” field is blank!image-20241205-161004.png|width=1335,height=568,alt="image-20241205-161004.png"! Click in the “TELEPHONE (OPTIONAL)” field then click out of field without entering any data, the error “This field must contain 10 numeric characters.” is displayed and “Contact” is unable to save. (THIS IS PART OF THE BUG)!image-20241205-161620.png|width=965,height=564,alt="image-20241205-161620.png"! NOTE: Repeat steps above on Edit Contact page by tabbing between fields. “TELEPHONE (OPTIONAL)” field after tabbing between fields the error “This field must contain 10 numeric characters.” is displayed and “Contact” is unable to save. (THIS IS PART OF THE BUG)NOTE: Repeat steps when creating a contact in a transaction, the same error is populating. “TELEPHONE (OPTIONAL)” field the error “This field must contain 10 numeric characters.” is displayed, unable to save. (THIS IS PART OF THE BUG)[~accountid:61b0b42cc510bc006b5c03ed] [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] Bug verified per user feedback during Sprint 52 testing. Pointed 2 pts and assigned to Sprint 52. |
|
Todd Lees commented: Adding e2e tests |
|
Sasha Dresden commented: Changed resolution to inside the onBlur effect. Added tests. |
|
Todd Lees commented: passes cr moving to qa |
|
Todd Lees commented: e2e tests |
|
Shelly Wise commented: QA review during retesting selected existing contact, changed state from Kansas to WV. I clicked in the telephone field, and the error was not populating which is correct. However, the confirm popup showed I removed telephone number, this is the error. !image-20241211-150744.png|width=1079,height=472,alt="image-20241211-150744.png"! [~accountid:61b0b42cc510bc006b5c03ed] [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] [~accountid:627ebeb2236090006f61d37d] talked with Sasha sending back to fix error. |
|
Sasha Dresden commented: Ah the issue was that empty phones are stored in the database as null, but I was clearing the phone number to prevent excess validation by setting it to undefined. Just used null instead and it’s working as intended. |
|
Todd Lees commented: passes cr moving to qa |
|
Shelly Wise commented: QA review verified bug fix . Changed state from Kansas to Virginia. I clicked in the telephone field, and the error was not populating which is correct. The confirm popup did not show I removed telephone number, this part of bug fixed. !image-20241212-150126.png|width=1253,height=384,alt="image-20241212-150126.png"! Verified telephone field is functioning as currently designed. !image-20241212-150427.png|width=380,height=154,alt="image-20241212-150427.png"! !image-20241212-150503.png|width=370,height=159,alt="image-20241212-150503.png"! QA Review Completed. Moved to Stage Ready. |
“I found another bug when creating a profile for the transaction. It says telephone is optional but it will not let me save and continue without adding a phone number.”
QA retested this bug. See steps to replicate issues in comment below.
QA Notes
null
DEV Notes
See replicated steps below for this ticket. [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] add to e2e tests for this bug
Design
null
See full ticket and images here: FECFILE-1861
The text was updated successfully, but these errors were encountered: