Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deptry hook to circle #1238

Open
exalate-issue-sync bot opened this issue Dec 4, 2024 · 3 comments
Open

Add Deptry hook to circle #1238

exalate-issue-sync bot opened this issue Dec 4, 2024 · 3 comments
Assignees

Comments

@exalate-issue-sync
Copy link

Add a step in circle to run deptry and fail if there are unused dependencies

QA Notes

null

DEV Notes

null

Design

null

See full ticket and images here: FECFILE-1878

Copy link
Author

Sasha Dresden commented: Pinned the version. Also I found an [extension|https://marketplace.visualstudio.com/items?itemName=Tyriar.sort-lines] that sorts lines. Doesn't do it automatically but really easy to use via vscode commands.

Copy link
Author

exalate-issue-sync bot commented Dec 12, 2024

Todd Lees commented: passes cr moving to qa

[https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4723/workflows/6da3c4ee-6e1f-4c58-b494-5eca4fbc70ce/jobs/13408|https://app.circleci.com/pipelines/github/fecgov/fecfile-web-api/4723/workflows/6da3c4ee-6e1f-4c58-b494-5eca4fbc70ce/jobs/13408]

dependency check working

!image-20241212-134614.png|width=965,height=241,alt="image-20241212-134614.png"!

Copy link
Author

Shelly Wise commented: QA review verified dependency check working for this ticket per DEV.

!image-20241212-145813.png|width=1494,height=618,alt="image-20241212-145813.png"!

QA Review Completed. Moved to Stage Ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants