Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify deployment steps to wait for new migrations to finish before deploying new app versions #1228

Open
exalate-issue-sync bot opened this issue Nov 29, 2024 · 0 comments
Assignees

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Nov 29, 2024

Original spike ticket: https://fecgov.atlassian.net/browse/FECFILE-1773

Diagram: https://docs.google.com/drawings/d/1HNd2piLJSSuYqqNbh_yGCTRyQFbEwOU2PSU4yX0QM_I/edit

![Screenshot 2024-11-29 at 3.21.45 PM.png](/attachments/13866?name=Screenshot 2024-11-29 at 3.21.45 PM.png)

  1. Migrations could be run by an app without a route
  2. Migrations should completely finish before new application versions are deployed
  3. Should probably modify the deploy task itself in (tasks.py). See https://github.com/fecgov/openFEC/blob/99b62ee48ac31fc352aaa287cc4304533c8328b2/tasks.py#L185-L212 for an example (flask/flyway but some of the basic principles are the same)
  4. Could possibly reuse deployer instance with no routes as a non-deployer instance after migrations (add route to the application instance afterwards)
  5. Take manage.py migrate out of the existing run-api.sh
  6. Test partially failed migrations / rollback

QA Notes

null

DEV Notes

null

Design

null

See full ticket and images here: FECFILE-1865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant