Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Update cloud.gov manifest setup in e-regs #380

Closed
2 tasks done
Tracked by #113
ccostino opened this issue Feb 20, 2018 · 3 comments
Closed
2 tasks done
Tracked by #113

Update cloud.gov manifest setup in e-regs #380

ccostino opened this issue Feb 20, 2018 · 3 comments
Assignees
Milestone

Comments

@ccostino
Copy link
Contributor

ccostino commented Feb 20, 2018

Manifest inheritance has been deprecated in Cloud Foundry in favor of another type of setup using something called a YAML anchor.

Instead of inheriting manifest files from each other, you declare a defaults section in your manifest file that other sections then reference. Unfortunately what this means for us is increased duplication since we have separate manifests for each space, but we want to make sure this is accounted for before the manifest inheritance is just shut off completely on us (this change happened about a year ago).

To update the API we'll have to do the following:

  • Copy everything in the base manifest file to their respective manifest files for each space
  • Make sure each manifest file for each space still works as expected
@lbeaufort
Copy link
Member

@ccostino it looks like the host attribute has been replaced with routes as well. I'll incorporate that into my changes

https://docs.cloudfoundry.org/devguide/deploy-apps/manifest.html#deprecated
The following route component attributes have been deprecated:
domain
domains
host
hosts
no-hostname

@patphongs
Copy link
Member

This work has been completed in #384. Just need to monitor stage and prod deploys to make sure they deploy correctly. But for all intents and purposes, this issue can be closed unless we have a problem deploying to the other spaces.

@ccostino
Copy link
Contributor Author

🎉 thank you, @lbeaufort and @patphongs! So far so good, everything looks okay to me and great catch on the other deprecated piece. :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants