-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fec.gov links to transition.fec.gov links #927
Comments
To clarify, redirects are a different task, that should be completed first and that gives us time for this task because if we don't find all the links right away, it will still be ok because they will redirect to the right place under our general rules. Though this task should still be done to keep the html clean. cms data contentWe will want to make the rewrite rules and then loop through the text data in the CMS finding and replacing those links with the correct, relative link. We started on a function here: We started making a task to loop through the models and apply the funcion (This has some sqlite specific stuff in it so this might be less important) - https://github.com/18F/fec-cms/blob/develop/fec/data_loader/management/commands/remake_links.py Links in the codeWe will want to look for those manually in all the repos |
Task for now: Update www.fec.gov links set in CMS pages to transition.fec.gov . |
@llienfec for transparency |
Thanks. Meeting with @patphongs tomorrow AM to talk about where we're at. Then will keep going w/ making changes as needed. |
Awesome! Let me know when/how you want more folks helping out with this! |
Legal resources is done for the most part. I have a couple of questions outstanding that I'll see if @emileighoutlaw is available to pair on. Will let @AmyKort know when it's ready to review. Dorothy is making good headway on the Record and press releases. Help for Candidates and Committees will be done soon. |
One the transition hybrid pages are up at transition.fec.gov we need to replace all links that currently go to the old site (fec.gov) to go to the transition pages.
For link re-writing, there's three use-cases we need to account for:
I'll leave it to @patphongs and/or @LindsayYoung to weigh in on the best method to do this, considering different options available like 301 redirects or changing the hard-coded values.
Whatever we do we need to account for:
Completion criteria:
The text was updated successfully, but these errors were encountered: