Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement/Create Commissioner bio page model and template #669

Closed
2 tasks done
Tracked by #60
noahmanger opened this issue Dec 17, 2016 · 7 comments
Closed
2 tasks done
Tracked by #60

Implement/Create Commissioner bio page model and template #669

noahmanger opened this issue Dec 17, 2016 · 7 comments
Assignees
Milestone

Comments

@noahmanger
Copy link

noahmanger commented Dec 17, 2016

So that users can find information about the biographies, statements, and actions of commissioners past and present, present commissioner information on a single page.


🖌 Designs

The design calls for a several unique values that I think make sense to just code into a new page model and template for these pages:

  • Picture
  • Dates served: Storing this data would make it easy to automatically generate the page of past commissioners and also to populate the current commissioners on the home page
  • Party affiliation
  • Email address
  • Twitter (optional, I'm assuming)

These are in addition to standard title and body content fields.

Once this model is created we can have other people help populate the content.

Completion criteria:

  • Create page model with all of the fields
  • Create new template as designed
@noahmanger noahmanger modified the milestone: Sprint 3 Dec 17, 2016
@noahmanger noahmanger added this to the Sprint 4 milestone Dec 30, 2016
@jenniferthibault jenniferthibault changed the title Create Commissioner page model and template Implement/Create Commissioner bio page model and template Jan 3, 2017
@xtine
Copy link
Contributor

xtine commented Jan 10, 2017

I noticed that some past commissioners have been re-appointed on http://www.fec.gov/members/formermembers.shtml

It seems to make sense to only sort by original appointment dates, but to also show reappointment dates if applicable underneath. If we aren't doing any sorting on the reappointment dates would it make sense to make the additional reappointment field as text in the CMS? Thoughts @noahmanger @jenniferthibault ?

Also there are the Ex-Officio commissioners to think about displaying as well.

@noahmanger
Copy link
Author

Just realized I never answered that question. I think that makes sense to just add them as an extra field. I'll keep this open for now.

@jenniferthibault
Copy link
Contributor

+1 to reappointment dates being an extra CMS field that would appear just below the original appointment
screen shot 2017-01-11 at 10 32 36 am

And thanks for pointing out the Ex officio commissioners, I totally missed them (heads up, @emileighoutlaw !)

How about using the same format & grid, minus the image field? Like this:

screen shot 2017-01-11 at 10 57 36 am

That would be placed at the bottom of the page of all Commissioners.

@emileighoutlaw
Copy link
Contributor

Yikes— I also totally forgot about the ex officio Commissioners. I think that looks great!

@emileighoutlaw
Copy link
Contributor

And I do like the existing description of ex officio (from the current page). The only tweak I'd make to the content is to move the court case into parentheses:

From 1975 through 1993, the Secretary of the Senate and the Clerk of the House were designated as nonvoting, ex officio Commissioners. In 1993, an appeals court ruled that the presence of nonvoting Congressionally appointed ex officio members on the Commission violated the Constitution’s separation of powers. The Supreme Court dismissed the Commission’s appeal for lack of jurisdiction (FEC v. NRA Political Victory Fund). Subsequent to the appeals court decision, the Commission reconstituted itself as a six-member body.

@jenniferthibault
Copy link
Contributor

Great! Yeah that case bit confused me, I couldn't tell why it was floating there.

@noahmanger
Copy link
Author

Resolved by #733 . Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants