-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement/Create Commissioner bio page model and template #669
Comments
I noticed that some past commissioners have been re-appointed on http://www.fec.gov/members/formermembers.shtml It seems to make sense to only sort by original appointment dates, but to also show reappointment dates if applicable underneath. If we aren't doing any sorting on the reappointment dates would it make sense to make the additional reappointment field as text in the CMS? Thoughts @noahmanger @jenniferthibault ? Also there are the Ex-Officio commissioners to think about displaying as well. |
Just realized I never answered that question. I think that makes sense to just add them as an extra field. I'll keep this open for now. |
+1 to reappointment dates being an extra CMS field that would appear just below the original appointment And thanks for pointing out the Ex officio commissioners, I totally missed them (heads up, @emileighoutlaw !) How about using the same format & grid, minus the image field? Like this: That would be placed at the bottom of the page of all Commissioners. |
Yikes— I also totally forgot about the ex officio Commissioners. I think that looks great! |
And I do like the existing description of ex officio (from the current page). The only tweak I'd make to the content is to move the court case into parentheses:
|
Great! Yeah that case bit confused me, I couldn't tell why it was floating there. |
Resolved by #733 . Good work! |
So that users can find information about the biographies, statements, and actions of commissioners past and present, present commissioner information on a single page.
🖌 Designs
The design calls for a several unique values that I think make sense to just code into a new page model and template for these pages:
These are in addition to standard title and body content fields.
Once this model is created we can have other people help populate the content.
Completion criteria:
The text was updated successfully, but these errors were encountered: