Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue viewing table rows in wagtail #5910

Closed
1 task
Tracked by #159
JonellaCulmer opened this issue Sep 13, 2023 · 2 comments · Fixed by #5983
Closed
1 task
Tracked by #159

Issue viewing table rows in wagtail #5910

JonellaCulmer opened this issue Sep 13, 2023 · 2 comments · Fixed by #5983
Assignees
Milestone

Comments

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented Sep 13, 2023

What we're after:
There's an issue in Wagtail that prevents users from seeing all created table rows. There are currently two unfriendly workarounds to address this: resizing the browser window until the rows appear, and deleting and re-adding a row. To address this issue we need to ensure consistent and reliable access to all rows without hacks.

Completion criteria:

  • All table rows are consistently viewable on all draft and published wagtail pages/templates with table functionality

Screenshots:

Audit published page: missing bottom 4 rows. This is also happening on draft pages.

Private Zenhub Image

Published E&J page: missing hundreds of rows

Private Zenhub Image

@johnnyporkchops
Copy link
Contributor

johnnyporkchops commented Sep 14, 2023

Below is a link to the commit where I fixed the hidden-table-row bug in Wagtail just for ReportingDatesTable template. It admittedly feels kinda hacky (cc:
@rfultz .) Also, it will be more difficult to target all occurances of the table-block in css because of the way the elements are named in the editor's html.

I was hoping this would just be resolved in newer versions of Wagtail , but surprisingly, I have not found many others complaining about/discussing it on Wagtail-related forums.

https://github.com/fecgov/fec-cms/pull/5786/files#diff-45aff0a8e79340d067150d806eca68e3490547069b6886f1c05278983f4b0673

@JonellaCulmer
Copy link
Contributor Author

@johnnyporkchops

Also, it will be more difficult to target all occurances of the table-block in css because of the way the elements are named in the editor's html.

I've updated the estimate to 3. If you think it's bigger than that, we can split the ticket up and target most important templates first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants