Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining press releases and weekly digests #589

Closed
2 tasks done
Tracked by #60 ...
noahmanger opened this issue Nov 7, 2016 · 9 comments
Closed
2 tasks done
Tracked by #60 ...

Add remaining press releases and weekly digests #589

noahmanger opened this issue Nov 7, 2016 · 9 comments

Comments

@noahmanger
Copy link

noahmanger commented Nov 7, 2016

We have the go-ahead to launch the press section this week, but we need to add content that has been published since we last imported. This will be easiest to just do by hand.

We need to:

cc @emileighoutlaw @jenniferthibault : Do you want to divvy this up at all?

@emileighoutlaw
Copy link
Contributor

I can add them if @jenniferthibault would be willing to do a round of QA when I'm done?

@jenniferthibault
Copy link
Contributor

Gladly! Also glad to split it up, whichever you prefer.

@emileighoutlaw can you give the Weekly Digests formatting guide from 18F/fec-style#544 a whirl to try it out? I think you'll be able to get straight to the template in wagtail through this: https://beta.fec.gov/admin/pages/4291/edit/

@emileighoutlaw
Copy link
Contributor

emileighoutlaw commented Nov 7, 2016

@jenniferthibault
Copy link
Contributor

Done!

Reviewed the press releases and digests @emileighoutlaw did, and made a few tiny tweaks. Nice work!

Slightly less great news: the h2's in all of the 2016 weekly digests that Noah and I formatted Use Title Case annnnd all the ones Emileigh did use Sentence case, which I know is the correct way. D'oh!

I'm about 1/2 way through fixing all of 2016's to be sentence case, and will finish in the morning.

@jenniferthibault
Copy link
Contributor

Scratch that, I hustled though them, and all of 2016 now has Sentence case categories.

@emileighoutlaw could I trouble you to take a quick general peek in the morning in case there were unwritten rules you were following that I may not have?

@emileighoutlaw
Copy link
Contributor

You're a star @jenniferthibault 🌟 I made a couple more small changes, but everything looks good to go to me!

One thing for @noahmanger — when I look at the list of Weekly Digests, I'm seeing the formatting guide in the list, even though it's not published. Any idea what's going on?
https://beta.fec.gov/updates/?update_type=weekly-digest

screen shot 2016-11-08 at 10 34 12 am

@noahmanger
Copy link
Author

Oooh I think I know what that is. Fix coming.

@noahmanger
Copy link
Author

Thank you!!!

@noahmanger
Copy link
Author

This is done. Thanks for adding, @jenniferthibault !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants