You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the final iteration of the changes to pres-finance-map-box.js for #4504, a breaking change was overlooked in testing : The open/close behavior of Export raising data area.
What happened?
User clicks Export raising data button to open downloads area and page scrolls to its location.
The ability to toggle the raising downloads area open/closed does not work once a user scrolls away from it and back to it on the page
If one closes it the first time it is opened, a scroll away and back will automatically open it
What should have happened?
This area should remain toggleable, once it is open by clicking the Export raising data button and maintain the user-chosen state (open/closed) while scrolling around
Frequency
Always
How to Reproduce
Device, browser, etc
Chrome/Opera/Firefox/Safari
Will need to test in MS Edge as we did for the passive listeners PR #4504 that introduced this and since passive listeners involve touchstart and scroll events, it is a good idea to test touch screen on MS Surface and Phones.
Possible solutions to consider:
Figure out how to maintain the original functionality while also achieving the passive listeners fix (look at previous iteration before passive listener PR 4504)
Remove the ability to close the area once it has been opened by user clicking Export raising data button (with UX approval)
Use the out-of-the-box accordion that we use on other pages, although I believe attempts at this were difficult the first time around, hence the current one-off html/js implementation.
The new scroll listener/function causes the height on the state-downloads links area to continue to calculate long after the scroll has stopped. This blocks the accordion toggle function from working until it finally finishes registering a value for every pixel the user scrolled.
Summary
In the final iteration of the changes to
pres-finance-map-box.js
for #4504, a breaking change was overlooked in testing : The open/close behavior of Export raising data area.What happened?
User clicks
Export raising data
button to open downloads area and page scrolls to its location.What should have happened?
This area should remain toggleable, once it is open by clicking the
Export raising data
button and maintain the user-chosen state (open/closed) while scrolling aroundFrequency
Always
How to Reproduce
Device, browser, etc
Chrome/Opera/Firefox/Safari
Will need to test in MS Edge as we did for the passive listeners PR #4504 that introduced this and since passive listeners involve touchstart and scroll events, it is a good idea to test touch screen on MS Surface and Phones.
Possible solutions to consider:
Export raising data
button (with UX approval)Comment on the issue on post-merged PR
https://github.com/fecgov/fec-cms/pull/4504/files#r615523787
The text was updated successfully, but these errors were encountered: