Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail wish list: In resource page template, allow the "related page" to be an external link #3794

Closed
1 task
Tracked by #138
dorothyyeager opened this issue May 29, 2020 · 4 comments · Fixed by #3995
Closed
1 task
Tracked by #138
Assignees
Milestone

Comments

@dorothyyeager
Copy link
Contributor

dorothyyeager commented May 29, 2020

Summary

What we are after:
In the resource page template, the "related page" block is used to generate the pages linked on the top right side as "read next."

Right now, we can only choose internal linked pages (so pages that are in Wagtail). There's no option to add an external link, which means we can't link in that spot to pages that are hard-coded (like data pages) , the transition page, or in some cases outside pages (like the IRS) that we might want to link.

Example of a "related page link" (the link in grey box, under red box labeled "read next")

image

Screenshot of what Wagtail user sees when generating that sidebar:

image

Related issues

#3445 Resource page image height wishlist item

Completion criteria

  • Wagtail users can use either an internal link or external link to do related page links in the resource page template.
@johnnyporkchops
Copy link
Contributor

@dorothyyeager, @kathycarothers. We don't have anything like ExternalLinkBlock currently, only ExternalButtonBlock, which renders as a button. I can make an ExternalLinkBlock though.
However, something else that I thought might be more versatile was a RichTextBlock option here, where you can always add a link to an external URL, but also put text in here as well, should the need ever arise.

Admin:

Screen Shot 2020-08-21 at 11 31 31 AM

Rendering:

Screen Shot 2020-08-21 at 11 39 04 AM

@dorothyyeager
Copy link
Contributor Author

@johnnyporkchops I'm good with that solution! It accomplishes what we needed. Tagging @JonellaCulmer in case she has any style u/x concerns about it.

@JonellaCulmer
Copy link
Contributor

@dorothyyeager @johnnyporkchops No issues, thanks for checking!

@kathycarothers
Copy link
Contributor

@johnnyporkchops I am good too with that solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants