Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail wish list: Reduce vertical space around table element #3541

Closed
2 tasks
Tracked by #138
dorothyyeager opened this issue Feb 11, 2020 · 1 comment · Fixed by #3970
Closed
2 tasks
Tracked by #138

Wagtail wish list: Reduce vertical space around table element #3541

dorothyyeager opened this issue Feb 11, 2020 · 1 comment · Fixed by #3970
Assignees
Milestone

Comments

@dorothyyeager
Copy link
Contributor

dorothyyeager commented Feb 11, 2020

Summary

What we are after:
Right now there is a little too much space around the table element. We would like to have less white space.

table padding

(The article this screenshot comes from is at https://www.fec.gov/updates/march-25-webinar-candidate-committees-2020/.)

Completion criteria

  • The vertical space between tables and other elements on the page should follow visual patterns from elsewhere on the site and the pattern library.
  • The pattern library should specify the updates if needed

Future work

@dorothyyeager dorothyyeager added this to the Sprint 11.6 milestone Feb 11, 2020
@rfultz rfultz changed the title Wagtail wish list: Reduce padding around table element Wagtail wish list: Reduce vertical space around table element Feb 26, 2020
@johnnyporkchops
Copy link
Contributor

We can add :

.body-block.block-paragraph + .body-block.block-table {
    margin-top: -4rem;
}

To accommodate for the default margin below body-block.block-paragraph when .a table block follows.
We could also add something for a table-block following another table-block but the spacing in the original screenshot seems like the expected separation between content blocks. Thoughts?

Screen-Shot-2020-02-26-at-8 16 34-PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants