Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues when posting reports about the FEC #3392

Closed
4 tasks done
dorothyyeager opened this issue Nov 26, 2019 · 4 comments
Closed
4 tasks done

Fix issues when posting reports about the FEC #3392

dorothyyeager opened this issue Nov 26, 2019 · 4 comments

Comments

@dorothyyeager
Copy link
Contributor

dorothyyeager commented Nov 26, 2019

Summary

What we are after:
As a user, I want to be able to find the reports posted by the FEC about the FEC.

Background
We've identified a couple of issues with reports posted about the FEC that are using the "resource page template" and we need to fix them. Right now the only pages using this are https://www.fec.gov/about/reports-about-fec/agency-operations/e-filing-study-2016/ and its child pages.

  1. Need to fix the template (front-end work): To select the category of report when using a resource page, you have to do so on the promote tab, choosing from a drop down menu. However, something is preventing the category that was selected from showing up, and is causing the page to appear in the wrong category. See the listing for "Modernizing the e-filing experience..." on https://www.fec.gov/about/reports-about-fec/agency-operations/?category=gift+report. This listing should not be included in this category, as "study" was the category assigned to it. See screenshot:

image

  1. The child pages of the e-filing page most likely were completely copied/pasted from Word and can't be opened for editing. They are returning 500 server errors and will need to be restored for editing using this: https://github.com/fecgov/fec-cms/wiki/Fixing-invalid-HTML-Wagtail-pages-that-error

  2. The page for the e-filing page needs some editing to make the text plain text rather than text that was copied/pasted from Word. It also needs SEO (see screenshot above; the fields for that are blank.) This is something content team could do.

Completion criteria

Front end

Content

@dorothyyeager
Copy link
Contributor Author

Related ticket for the fixing needed for the e-filing pages at #3459 so I've added dependency.

@pkfec
Copy link
Contributor

pkfec commented Mar 3, 2020

@dorothyyeager Resource pages under FEC/Modernizing the E-filing experience and infrastructure all are editable. These pages were fixed here #3459.

The category on these pages is empty NOW in dev, stage and prod spaces. can you go ahead and test by updating the categories on these pages and see if that fits your need.

@dorothyyeager dorothyyeager self-assigned this Mar 3, 2020
@dorothyyeager
Copy link
Contributor Author

Thanks @pkfec - the front end issue is fixed and the e-filing study is showing up as a "study." Taking Priya off and assigning myself to finish out the issue.

@dorothyyeager
Copy link
Contributor Author

dorothyyeager commented Mar 3, 2020

The rich text editor issues with these pages have been fixed and the pages render like they are supposed to now. Thanks again @pkfec , turned out to be a very easy fix for me because of your hard work. Now https://www.fec.gov/about/reports-about-fec/agency-operations/e-filing-study-2016/ and all of its child pages are looking sharp and the report can be found in the "Study" category. Closing the ticket as the work is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants