Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS Styles for TV ad examples #3373

Closed
2 tasks done
Tracked by #164
johnnyporkchops opened this issue Nov 20, 2019 · 1 comment · Fixed by #3812
Closed
2 tasks done
Tracked by #164

CSS Styles for TV ad examples #3373

johnnyporkchops opened this issue Nov 20, 2019 · 1 comment · Fixed by #3812
Assignees
@johnnyporkchops
Labels
Work: Front-end
Milestone
Sprint 12.5

Comments

@johnnyporkchops
Copy link
Contributor

johnnyporkchops commented Nov 20, 2019 •
edited
Loading

Summary

What we're after:
We need to move CSS in the advertising reporting examples to SCSS files, instead of having it in the html block. It could probably go in components/_responsive-object.scss

Draft page:
https://fec-prod-proxy.app.cloud.gov/admin/pages/10616/edit/preview/

Related issues

#3179

Action Items

  • Remove CSS from any html blocks using the TV ad example iframe background image.
  • Add or edit classnames where necessary html block in Wagtail and in components/_responsive-object.scss for semantic clarity
@dorothyyeager dorothyyeager added this to the PI 11 planning milestone Dec 6, 2019
@pkfec pkfec modified the milestones: Sprint 11.6, Sprint 12.1 Mar 3, 2020
@JonellaCulmer JonellaCulmer removed this from the Sprint 12.1 milestone Apr 6, 2020
@JonellaCulmer JonellaCulmer added this to the Sprint 12.5 milestone May 7, 2020
@djgarr
Copy link
Contributor

djgarr commented Jun 2, 2020

@johnnyporkchops do you need anything from Content Team for this ticket?

@johnnyporkchops johnnyporkchops mentioned this issue Jun 3, 2020
Merged
4 tasks
@djgarr djgarr mentioned this issue Jul 22, 2020
Closed
5 tasks
@patphongs patphongs mentioned this issue Feb 29, 2024
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnnyporkchops johnnyporkchops

Labels
Work: Front-end
Projects
None yet
Milestone
Sprint 12.5
Development

Successfully merging a pull request may close this issue.

Add tv ad-example styles to SCSS fecgov/fec-cms
5 participants
@johnnyporkchops @pkfec @dorothyyeager @JonellaCulmer @djgarr