Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft methodology for IE version/deduping #3360

Closed
3 tasks
JonellaCulmer opened this issue Nov 18, 2019 · 12 comments
Closed
3 tasks

Draft methodology for IE version/deduping #3360

JonellaCulmer opened this issue Nov 18, 2019 · 12 comments

Comments

@JonellaCulmer
Copy link
Contributor

What we're after:
We need to better explain the differences between the different versions regarding deduped IEs: current version, past version and unknown version. From our user testing it was clear that users were unsure what we meant by unknown version and how we arrived at those classifications for each version. We need to explain this in our methodology.

Related issues

Completion criteria

  • Draft IE versioning methodology
  • Discuss necessary content changes with content team
  • Make any appropriate design changes based on review

Designs

Upon selecting "Version methodology" a pop-up will open on screen with the methodology.
Methodology Copy

@PaulClark2
Copy link
Contributor

Do we need to explain "version unknown?" I think that's what happens when the API cannot determine the current version. Is that correct @JonellaCulmer Do we need to explain how we determine the most recent filing in an amendment chain? It's the filing with the largest report id (also called file number)?

@dorothyyeager can you take a look at the draft? Also, anyone else on the team that want to comment, please do.

DRAFT:

Current version is the most recent filing in an amendment chain. For example, a report amendment might include the original (new) report, amendment #1 and amendment #2. Checking "current version" will display transactions disclosed on amendment #2.

@PaulClark2
Copy link
Contributor

Do we want to describe each version: "current," "past" and "unknown?"

@dorothyyeager
Copy link
Contributor

@PaulClark2 I think you might want to describe all of them, especially "unknown."

Want to ask something before I comment on draft. By amendment chain, do we mean a report, an amendment, and then an amendment of the amendment? Or do we just mean the report plus all amendments to it?

@dorothyyeager
Copy link
Contributor

Also, if one selects "version unknown" do they get the original plus amendments?

@dorothyyeager
Copy link
Contributor

Here's my stab at it so far, but as you can see from my questions, I may not understand what people are able to select. @PaulClark2

A report amendment might include the original (new) report and several amendments. Checking “current version” will display transactions disclosed on the most-recently filed amendment. Checking “past version” will display transactions disclosed on the amendment(s) filed before the most recent one. “Version unknown” means that the API is unable to determine whether the report is an original or an amendment.

@JonellaCulmer
Copy link
Contributor Author

Hi @PaulClark2. Yes, we need to explain how we determine that something is unknown.

@PaulClark2
Copy link
Contributor

Second try. cc: @dorothyyeager @JonellaCulmer @hcaofec

When you check "current version," the website will display transactions disclosed on current version and unknown version reports.

Current version transactions are those transactions disclosed on the most-recently filed amendment. A report amendment might include the original (new) report and several amendments. Those marked current version were disclosed on most-recently filed amendment.

Unknown version transactions are those transactions disclosed on reports the API could not determine the version. This happens when an amendment might not associated with previous versions of the report.

Past version transactions are those transactions disclosed on reports that are not the most-recently filed amendment.

@dorothyyeager
Copy link
Contributor

Tightened it up a little; see if this works... Also if users understand "current" vs. "past" we could consider deleting that last sentence. @PaulClark2 @JonellaCulmer

When you check "current version," the website will display “current version” and “unknown version” transactions.

Current version transactions are those transactions disclosed on the most-recently filed amendment.
A report amendment might include the original (new) report and several amendments.

Unknown version transactions are those transactions disclosed on reports where the API could not determine the version because an amendment might not have been associated with previous versions of the report.

Past version transactions are those transactions disclosed on reports that are not the most-recently filed amendment.

@JonellaCulmer
Copy link
Contributor Author

@PaulClark2 I think what you've written is great with @dorothyyeager's minor changes. I would, however, keep the second 'paragraph' together, as Paul had it originally. And not on a separate line.

@dorothyyeager
Copy link
Contributor

Hmm, both our drafts are four paragraphs? My second paragraph looks like it's on two separate lines but that's just where word wrap landed.

@PaulClark2
Copy link
Contributor

@patphongs I think this is the final version unless Dorothy and I have misunderstood Jonella's comment.

When you check "current version," the website will display “current version” and “unknown version” transactions.

Current version transactions are those transactions disclosed on the most-recently filed amendment. A report amendment might include the original (new) report and several amendments.

Unknown version transactions are those transactions disclosed on reports where the API could not determine the version because an amendment might not have been associated with previous versions of the report.

Past version transactions are those transactions disclosed on reports that are not the most-recently filed amendment.

@patphongs
Copy link
Member

Updated Current version PR #3438 with the latest methodology above. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants