Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reaction box for WCCF feature #3237

Closed
3 tasks
Tracked by #140 ...
JonellaCulmer opened this issue Oct 7, 2019 · 4 comments · Fixed by #3302
Closed
3 tasks
Tracked by #140 ...

Implement reaction box for WCCF feature #3237

JonellaCulmer opened this issue Oct 7, 2019 · 4 comments · Fixed by #3302
Assignees
Milestone

Comments

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented Oct 7, 2019

What we're after: To support the release and track usability needs, we should implement the reaction box below the WCCF to solicit for feedback.

This feedback will be tracked and recorded by @JonellaCulmer

Completion criteria:

  • See previous implementation and confirm that questions/form boxes used apply to this feature. Last used on line chart on data landing page and raising and spending browse data pages. Confirm questions with @JonellaCulmer
  • Implement reaction box that solicits for and sends feedback to the FEC github repo.
  • Open up follow-up ticket to take down reaction box approximately 2 months from the time of the launch.

Reaction box screenshot

Screen Shot 2019-10-07 at 11 09 36 AM

@johnnyporkchops
Copy link
Contributor

johnnyporkchops commented Oct 24, 2019

@JonellaCulmer. Do you remember if there where issues with the recaptcha placement on the form for the reaction box when this was previously implemented on the line charts on browse-data? It is defaulting to a little off in terms of placement

@JonellaCulmer
Copy link
Contributor Author

@johnnyporkchops No, I don't recall there being issues with the placement. I do recall some issues though with the questions and I'm struggling to find a PR that Andrew put in as he was the last person to get them implemented.

@lbeaufort
Copy link
Member

@JonellaCulmer @johnnyporkchops here are some relevant PRs:

Add reaction box: #2276
Remove reaction box: #2510

@patphongs
Copy link
Member

For the reaction box recaptcha badge replacement, I recall that we decided to place it on the left side of the screen. Because the reaction box has a comment area that appears after a user selects a reaction, we couldn't really place the badge next to the submit button as we would want the user to know that recaptcha is there prior to use of the tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants