Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page watch template tags for govdelivery into Wagtail templates #3081

Closed
5 of 8 tasks
Tracked by #113
dorothyyeager opened this issue Jul 29, 2019 · 15 comments
Closed
5 of 8 tasks
Tracked by #113
Assignees
Milestone

Comments

@dorothyyeager
Copy link
Contributor

dorothyyeager commented Jul 29, 2019

Summary

What we are after:
We needed to suspend govdelivery pagewatches due to excessive emails triggered from a security implementation for csrftoken. We now need to add govdelivery template tags so that pagewatch only monitors only part of a web page

Related issues

Completion criteria

Dorothy:

  • Go into GovDelivery and set each topic's Watched Tagged Content to "yes"
  • Copy the page watch content block code for each topic into the spreadsheet (in shared google drive in folder called "govdelivery")

image

  • Note if page being watched is hard coded or in CMS.
  • Note the specific content on the page that we are trying to watch and anything else that might be helpful.

Once Dorothy's done; turn over to John to:

  • Insert the pagewatch tags as needed into each hard-coded page template. This page contains the tags info: https://support.granicus.com/s/article/Automating-Updates-on-Webpage-or-File-Content-by-Email.
  • For CMS pages, research how to do this, especially for pages like Dates and Deadlines that have numerous codes to insert. Do we insert using HTML blocks? (Answer: yes for custom page; John will look into template modifications for Resource and Document Feed pages).
  • See what if anything we can do about watching YouTube page content.
  • Test that the tags are working
@johnnyporkchops
Copy link
Contributor

johnnyporkchops commented Jul 29, 2019

@dorothyyeager , regarding the CMS templates. We could add a dropdown inside certain templates that would allow you to choose to tag a certain section with a specific pagewatch tag. Or just a pagewatch field in which you manually input the topic ID and it would wrap that section in a pagewatch tag when rendered. If most of pages we want to watch are built on only a few different template-types (ie- ResourcePage, CoolectionPage etc.) and the pertinent content is typically put into a certain field types (ie sections, body , etc) maybe this would not be that complicated.

@dorothyyeager
Copy link
Contributor Author

That sounds good @johnnyporkchops - I'll update the spreadsheet to note which template a CMS page is using.

@dorothyyeager
Copy link
Contributor Author

I've got all of the topics updated except for the YouTube ones. Will send the spreadsheet to @johnnyporkchops and re-assign the issue to him for the front-end work.

John: There are a couple of files that are transition files, so if it's helpful for me to add the tags on those, I can do that via Contribute.

@dorothyyeager
Copy link
Contributor Author

I've put the spreadsheet in our shared google drive in the "govdelivery" folder.

@dorothyyeager
Copy link
Contributor Author

dorothyyeager commented Aug 2, 2019

@johnnyporkchops and I are going to start tagging. I'll do the custom page CMS and transition page tags. He'll do the hard-coded ones. He may look into modifying templates like the Resource Page template and the Document Feed page template to add a drop down way to select the applicable code.

Spreadsheet is here.

@AmyKort
Copy link

AmyKort commented Aug 2, 2019

Thank you both SO much!

@dorothyyeager
Copy link
Contributor Author

The custom page (there was only one) and the four transition page tags have been added. This weekend will be a good test to see if it worked.

@dorothyyeager
Copy link
Contributor Author

We found that the transition page watch tags are working. The custom page watch tag is not. Since that one and all the rest we need to add involve Wagtail, we need to make sure we're setting this up right with our CMS. @johnnyporkchops and I have reached out to our Gov Delivery contact to set up a call and ask our questions.

@dorothyyeager
Copy link
Contributor Author

We're going to set up a call with the govdelivery contact during this sprint and ask our questions. We also will talk with InfoDiv about the need for page watch at all. Moving to blocked until we get our questions answered, which will help us decide what to do with the rest of the work.

@dorothyyeager
Copy link
Contributor Author

We just had our call and will email support with our more technical questions. We learned that due to changes on YouTube's end, it doesn't really work for YouTube anymore, so have ticked that box.

@lbeaufort
Copy link
Member

@dorothyyeager are we still waiting for answers from InfoDiv on this?

@dorothyyeager
Copy link
Contributor Author

@lbeaufort Not Info Div. We're blocked waiting on Gov Delivery to answer our support tickets. @johnnyporkchops have you heard back from them? We may need to make a decision about how long we want to wait on Gov Delivery.

@patphongs
Copy link
Member

@johnnyporkchops @dorothyyeager Can we escalate this ticket in GovDelivery so that we get an answer sooner? Maybe bring it up the chain at the FEC?

@dorothyyeager
Copy link
Contributor Author

We got some preliminary answers from GovDelivery and they are having me test out page watch on the one custom page where we inserted tags. I'm not sure they really answered @johnnyporkchops larger questions though. We'll keep talking with them.

@JonellaCulmer JonellaCulmer modified the milestones: Sprint 10.2, Sprint 10.3 Oct 7, 2019
@dorothyyeager
Copy link
Contributor Author

We've not been able to get an answer from GovDelivery that indicates that page watch notification tags are going to be useful for us. They don't seem to play well with the CMS.

Luckily, it's very easy to still generate bulletins without page watch. After talking with @AmyKort, we're going to schedule an internal meeting with the Info Division manager and hopefully we'll be able to disable page watch, as it isn't able to do for us what it is intended to do. Closing this ticket and will open a new one if any work results from that meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants