-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page watch template tags for govdelivery into Wagtail templates #3081
Comments
@dorothyyeager , regarding the CMS templates. We could add a dropdown inside certain templates that would allow you to choose to tag a certain section with a specific pagewatch tag. Or just a pagewatch field in which you manually input the topic ID and it would wrap that section in a pagewatch tag when rendered. If most of pages we want to watch are built on only a few different template-types (ie- |
That sounds good @johnnyporkchops - I'll update the spreadsheet to note which template a CMS page is using. |
I've got all of the topics updated except for the YouTube ones. Will send the spreadsheet to @johnnyporkchops and re-assign the issue to him for the front-end work. John: There are a couple of files that are transition files, so if it's helpful for me to add the tags on those, I can do that via Contribute. |
I've put the spreadsheet in our shared google drive in the "govdelivery" folder. |
@johnnyporkchops and I are going to start tagging. I'll do the custom page CMS and transition page tags. He'll do the hard-coded ones. He may look into modifying templates like the Resource Page template and the Document Feed page template to add a drop down way to select the applicable code. |
Thank you both SO much! |
The custom page (there was only one) and the four transition page tags have been added. This weekend will be a good test to see if it worked. |
We found that the transition page watch tags are working. The custom page watch tag is not. Since that one and all the rest we need to add involve Wagtail, we need to make sure we're setting this up right with our CMS. @johnnyporkchops and I have reached out to our Gov Delivery contact to set up a call and ask our questions. |
We're going to set up a call with the govdelivery contact during this sprint and ask our questions. We also will talk with InfoDiv about the need for page watch at all. Moving to blocked until we get our questions answered, which will help us decide what to do with the rest of the work. |
We just had our call and will email support with our more technical questions. We learned that due to changes on YouTube's end, it doesn't really work for YouTube anymore, so have ticked that box. |
@dorothyyeager are we still waiting for answers from InfoDiv on this? |
@lbeaufort Not Info Div. We're blocked waiting on Gov Delivery to answer our support tickets. @johnnyporkchops have you heard back from them? We may need to make a decision about how long we want to wait on Gov Delivery. |
@johnnyporkchops @dorothyyeager Can we escalate this ticket in GovDelivery so that we get an answer sooner? Maybe bring it up the chain at the FEC? |
We got some preliminary answers from GovDelivery and they are having me test out page watch on the one custom page where we inserted tags. I'm not sure they really answered @johnnyporkchops larger questions though. We'll keep talking with them. |
We've not been able to get an answer from GovDelivery that indicates that page watch notification tags are going to be useful for us. They don't seem to play well with the CMS. Luckily, it's very easy to still generate bulletins without page watch. After talking with @AmyKort, we're going to schedule an internal meeting with the Info Division manager and hopefully we'll be able to disable page watch, as it isn't able to do for us what it is intended to do. Closing this ticket and will open a new one if any work results from that meeting. |
Summary
What we are after:
We needed to suspend govdelivery pagewatches due to excessive emails triggered from a security implementation for csrftoken. We now need to add govdelivery template tags so that pagewatch only monitors only part of a web page
Related issues
Completion criteria
Dorothy:
Once Dorothy's done; turn over to John to:
The text was updated successfully, but these errors were encountered: