-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination back to datatables pages #3041
Comments
FYI- The Pattern Library patter library has the alternate design patterns for showing estimated page counts and numbered buttons. |
@johnnyporkchops Thanks, John! I've updated the ticket. |
@johnnyporkchops I spoke too soon. This doesn't include controls on how to change the number of items seen on a page. I'll mock something up today or tomorrow. |
@johnnyporkchops What do you think about below? |
I've updated the mock-up in the original comment based on previous discussions. |
@JonellaCulmer, something that came up in discussion - can you show what the pagination would look like for a large results set - such as all 2020 schedule A data? It has 1,078,296 pages: https://api.open.fec.gov/v1/schedules/schedule_a/?api_key=DEMO_KEY&two_year_transaction_period=2020 |
@lbeaufort A previous version of the pagination accounted for all pages. Listing pages 1, 2, 3...through to 1,000,000, etc. But that would add some visual clutter and confusion. And I'm not at all convinced that a user would page that far through the results without introducing new filters or sorting the data another way. I'm comfortable only listing some of the upcoming pages, not all of them. |
@rfultz Here's some mock-ups to account for the other states. Happy to chat further if you think it necessary. The first shows that a page will move to the middle, if possible. The last shows what it looks like to be on the last page. With the page all the way to the right and the right pagination button disabled. |
What we're after: In an effort to help orient our users when viewing multiple pages of data, we should update our pagination to include the number of results being viewed and total results. Presently, a user must rely on whether they notice the data in the table has changed with no confirmation. If a user clicks multiple times they may lose track of where they are in the list.
Before
After
Completion criteria:
The text was updated successfully, but these errors were encountered: