-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement schedule_a filter interaction changes for all receipts, indiv. contrib. #2811
Comments
Below is a first draft for the modified front-end time period filter. The view in its entirety is on the right and shows what it would look like for the two-year period selections, specific data filter and then the day-day view including month and year selectors. I do have some preliminary questions though. I want to make double sure that we must use a two-year period on the front-end. Could we not present single years on the front-end but the API/database would look within the relevant two-year period? Also, the tooltip language would need to change. Currently it says the following: |
We've had some preliminary discussion about what we're hoping to do to on the front-end. But we still need to discuss some of the logic. Moving this ticket to blocked and out of 8.5 so we can make room for that discussion. |
Following a discussion on 4/23, we're going to proceed with the following business logic:
|
After additional discussions on 4/25, the following mock-ups were made for the receipts datatable. If we proceed in this direction, these same (or very similar changes) will also need to be made to the individual contributions datatable. Other, less involved, changes still need to be mocked up for the disbursement datatables. Screen 1: Receipts - single period: Screen 2: Receipts - multi-period view 1: Screen 3: Receipts - multi-period view 2: Screen 4: Receipts - multi-period view 3: |
@patphongs Here's what I have so far for the Receipts filter panel. this incorporates our discussions up to this point to try to keep the filters in a single panel instead of split out. Receipts filter panelIndividual contributions filter panelDisbursements filter panel |
Thanks @JonellaCulmer, here's the workflow diagram for message states that we worked on together. |
In the previous two comments, there are mock-ups and a workflow for different success and error messages. Below is a complete list. If you wouldn't mind taking a look and providing feedback sometime during 8.7 while @patphongs is working on the front-end implementation, that would be great. Messages
We also plan to add static text below the time period filters that reads: I like the direction of that message, and it's short, but I think it needs to be more clear that not ALL of those filters/fields are required. Just "at least one". There are also some name changes to some of the filter groupings, like "More contributor details" not sure what else to call that. So really, anywhere there's words, I'd like a review, if possible. |
The messages in bullet points seem fine to me. You might want @bmathesonFEC to take a look too as he's more used to searching data than I am. For your static text, does this work? "When searching multiple time periods, choose at least one field (or more if desired): recipient name or ID, contributor name or ID, city, ZIP code, occupation or employer, or image numbers." Does ID in this case mean an ID number or contributor details? For "contributor details" - do you mean name, address, occupation, employer? You could use "identification" - because that's a glossary word for those items that they could look up. |
These look really good to me. I agree with @dorothyyeager about the static text suggestion. Maybe we don't even need (or more if desired) if we have at least one field in the message. |
"When searching multiple time periods, choose one or more fields: recipient name or ID, contributor name or ID, city, ZIP code, occupation or employer, or image numbers." |
That looks great to me! Thanks @dorothyyeager and @AmyKort. @dorothyyeager Contributor details in the top section made sense to me, but the section below that with just |
Do we want to move this to 9.1 for now? |
@JonellaCulmer When you get the chance, can you show me the design for a disabled accordion? Do we have an existing style for this? |
@patphongs Here are two mockups of what the receipts, and also the indiv. contrib. filter panels will look like when specific filters are disabled. Let me know if you have questions. Happy to take a closer look at this with you. |
User story: As a data user, I need to be able to increase my time period selection filter larger than a single 2 year time period for receipts and disbursements data so that I can view and filter data for that expanded time span.
What we're after: In order to successfully remove the two-year restriction from the all receipts, individual contributions and disbursements data tables, we need to consider what changes to the front-end interaction need to look like as well.
As an MVP, we're going to make the two-year period search consecutive, and not allow for users to choose random two-year periods. This changes the front-end interaction from its current implementation, although we do hope to retain both the two-year period selection as whole as well as allow for users to select between two year periods.
Example: User selects2015-2016 and 2017-2018. This search should return results. The user should also be able to refine this search to also specify specific dates with these full two-year periods such as 03/01/2016-10/01/2018 and should get results.
Completion criteria:
Update front-end implementation issue, 2812 with mockup and completion criteria based on mockupMaking this issue the front end ticket as well, since a lot of the thread about design and implementation is in this ticket.The text was updated successfully, but these errors were encountered: