Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ADR canonical page #2437

Closed
6 tasks
Tracked by #139
patphongs opened this issue Oct 11, 2018 · 2 comments
Closed
6 tasks
Tracked by #139

Implement ADR canonical page #2437

patphongs opened this issue Oct 11, 2018 · 2 comments
Assignees
Labels
ADR/AF pages Implementation of ADR/AF pages on .gov Work: Front-end Work: UX/Design
Milestone

Comments

@patphongs
Copy link
Member

patphongs commented Oct 11, 2018

What we're after: Using the design created below and data moved to the API in 7.2, we want to begin to implement the front-end
canonical pages for ADR pages.

We're basing this first iteration on the MUR pages currently implemented in production. See example linked above.

Updated mockup following conversations during design sync and dev pairing.
screen shot 2018-09-18 at 10 58 30 am

Completion criteria:

  • Make the ADR cannonical page.
  • Send to ADR for review.
    • Ask about penalties that show as $0 vs penalty that shows as just blank
    • Ask about whether or not blank in the disposition penalty and citation columns are ok
    • Ask about whether or not blank is ok for Subject, Complainant, and Election Cycle within the summary section
  • Add feature flag for ADR cannonical page.
@JonellaCulmer
Copy link
Contributor

Per your comments, @patphongs, I made some adjustments to the mock-up. Please see below. Happy to discuss further in design sync.

screen shot 2018-10-19 at 10 41 03 am

@patphongs
Copy link
Member Author

patphongs commented Oct 19, 2018

Per our design sync conversation, noting some of the updates here:

  • Subject and Complainant and Election Cycles fields can be empty. For content review purposes, will leave one field as "none" and the other blank
  • Remove trailing semicolon from election cycle listing
  • Disposition table: Data for penalty and citation columns are not always present. Decided to leave this blank until we hear back from SMEs
  • Added "Disposition" from commission votes to summary section
  • Remove Legal citations section as this was decided that we did not need it since it's noted already under Disposition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR/AF pages Implementation of ADR/AF pages on .gov Work: Front-end Work: UX/Design
Projects
None yet
Development

No branches or pull requests

2 participants