Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test candidate profile pages #2344

Closed
4 tasks done
patphongs opened this issue Sep 10, 2018 · 6 comments
Closed
4 tasks done

Test candidate profile pages #2344

patphongs opened this issue Sep 10, 2018 · 6 comments
Assignees

Comments

@patphongs
Copy link
Member

patphongs commented Sep 10, 2018

After the refactor of the candidate profile pages to fix 404's for future cycle candidates without committees, we need to test to make sure candidate profile pages are all functioning. Please test in our staging environment: https://fec-stage-proxy.app.cloud.gov/data/candidates

1 known issue with 404 on past candidates with no financial activity in 2018 has already been logged: #2343

Completion criteria:

  • Test future and past House candidates
  • Test future and past Senate candidates
  • Test future and past Presidential candidates
  • Ensure that future cycles show up for candidates who are running in future election cycles
@llienfec llienfec self-assigned this Sep 10, 2018
@llienfec
Copy link
Contributor

@patphongs I think this is a problem with terminated committees. After we got off our call, I tested 3 more and all had 404s. I'll test other committees, but for now, that's where I'd focus my time.

Here's a link to my API pull of terminated committees. Each has a candidate ID number so you can test in staging:
https://api.open.fec.gov/v1/committees/?sort=name&api_key=DEMO_KEY&page=1&committee_type=H&per_page=20&filing_frequency=T

@patphongs
Copy link
Member Author

2017-2018 data is displayed for Obama's presidential candidate profile even though the election year is 2012: https://fec-stage-proxy.app.cloud.gov/data/candidate/P80003338/

@llienfec
Copy link
Contributor

llienfec commented Sep 11, 2018

So far, the pages that are 404ing are terminated committees. I still haven't tested specials. @patphongs tested some candidates where their committees changed from House to Senate.

House testing

  • Past House, terminated:
    Duncan Hunter H2CA42023 – 404
    Wilbert Tauzin H0LA03018 - 404
  • Past House, still filing no activity – Clint Moore H4TX02082 – works
  • Past House, still filing & has activity - Wilbert Tauzin H4LA03069 – works
  • Current house – Veronica Escobar H8TX16109 - works
  • Having trouble finding a future House to test. This is an edge case.

Senate testing

  • Past Senate, terminated:
    Walter Mondale S2MN00019 – 404
    Robert Dole S4KS00010 – 404
  • Past Senate, still filing no activity – John McMullen S8VT00059 – works
  • Past Senate, still filing & has activity – Leonard Britton S0VT00114 – works
  • Current Senate – Sherrod Brown S6OH00163 – works
  • 2020 Future Senate – John Cornyn S2TX00106 – works
  • 2022 Future Senate – Todd Young S6IN00191 - works

President testing

  • Past presidential, terminated – Walter Mondale P40000267 – 404
  • Past presidential, still filing – Mitt Romney P80003353 – works
  • 2020 presidential, filing:
    Donald TrumpP80001571 – works
    Hart Cunningham P00006825 - works

@llienfec
Copy link
Contributor

@patphongs Do you still need more information or is this enough research?

@llienfec
Copy link
Contributor

Testing is related to #2343

@patphongs
Copy link
Member Author

Thanks for researching @llienfec, we will use some of these testing results and ideas when we create a new testing after the code is fixed up more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants