Legal AO bugs / improvements

[patphongs]

After testing the AO section of the website during the React 16 upgrade (fecgov/fec-cms#2307), there are additional issues that were found and improved. https://www.fec.gov/data/legal/search/advisory-opinions/. These bugs are unrelated to the upgrade.

• The “Entity name” search does not show all possible results.

• On https://fec-feature-cms.app.cloud.gov/data/legal/search/advisory-opinions/, the search filters work, but maybe not as effectively as they could. Some examples:

  • Searching "Al Franken" as requester gave me too many results, and some that were frankly not right. (I did get his AO though).

  • I put "114.2(f)" as my keyword and got way too many wacky results. Not sure why. Putting 114.2 into the "citations" search yielded the right AOs, but I couldn't narrow the reg to 114.2(f).

  • Searching requester type "corporation" yielded LLCs too. Other types of requester types also seemed to yield too much - "Individual" gave me more than "individuals" for example.

• Not sure the requestor search is working well. It is working, but the results are very mixed. Some examples:

  • AO 2008-06 and AO 2001-11 both were filed by the Democratic Party of Virginia, but AO 2008-06 comes up as "Virginia Democrats". So if you search "Virginia" in the AO requester field, they both come up. A search for "Democratic" and "Virginia" brought up both of them plus a lot of other party AOs.

  • When I search for “DSCC,” I get nothing, but when I search “Franken,” it returns “Franken/DSCC.” Other requestor name return without a hitch.

  • Searched for DSCC in requestor name after reading Chris' comment. I should have had several results but got none. I did get the desired results when I put "Democratic Senatorial Campaign Committee" in as a keyword using all of the above words. But it should have come up with the requestor name.

• Keyword still has the issues. I tried "facilitation" and got too many irrelevant results.