Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate raising/spending tab "compare" button taking users to the wrong election profile pages #2321

Closed
Tracked by #143
lbeaufort opened this issue Aug 29, 2018 · 3 comments

Comments

@lbeaufort
Copy link
Member

lbeaufort commented Aug 29, 2018

If a user is on a candidate raising/spending page on an off-election year and clicks "Compare to opposing candidates" they will be taken to an election profile page where the candidate isn't running. We need to pass the election_year for the button rather than the two_year_period.

Example:
Go to https://www.fec.gov/data/candidate/S2MA00170/?tab=raising&cycle=2014&election_full=false

Click the "Compare to opposing candidates" button
screen shot 2018-08-29 at 4 53 46 pm

screen shot 2018-09-18 at 10 57 47 am

You're taken to the 2014 election profile page, where the candidate did not run: https://www.fec.gov/data/elections/senate/MA/2014/

@patphongs
Copy link
Member

Check special candidates, past and current presidential candidates.

Example special candidate:

  • Jon Ossoff had a special in 2017
  • Doug Jones
  • Luther Strange

@patphongs
Copy link
Member

Looks like more work needs to be done for specials on this issue: #2340 (comment). Moving this to 7.2.

@patphongs patphongs modified the milestones: Sprint 7.1, Sprint 7.2 Sep 18, 2018
@AmyKort
Copy link

AmyKort commented Sep 28, 2018

Should we move this ticket to 7.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants