Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Filings tab and add image number to filings on candidate profile pages #2154

Closed
6 tasks done
Tracked by #143
JonellaCulmer opened this issue Jun 29, 2018 · 3 comments
Closed
6 tasks done
Tracked by #143

Comments

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented Jun 29, 2018

What we're after: To add more clarity and consistency across our profile pages, we need to create a Filings tab and move the bulk of candidate filings to that section.

While we plan to create that tab, we also need to keep the candidate's current version of their Statement of candidacy on the About this candidate tab. That way, users familiar with this placement will not be without it, or we introduce a pain point for them. Additional work is outlined below in the completion criteria, include the addition of filing image number to the tables.

Completion criteria:

  • Create "Filings" tab, list last after "Spending by others to support or oppose"
  • Add logic to "About this candidate" tab to list only the candidate's current version of their Form 2 Statement of candidacy
  • Create a 'Statements of candidacy' table on "Filings" tab, include all versions including current version
  • Move Other documents table from "About this candidate" tab to "Filings" tab. This table should follow the Statements of candidacy table
  • Include document "Image number" in Statements of candidacy table. Order of columns should be: Document > Version > Date filed > Image number > Pages
  • Update side nav and subnav items to correspond with new sections. Under Filings, Statements or candidacy and Other documents should be listed. Under About this candidate, Candidate information and Committees should be listed, and Other documents removed.

Designs:

Update about this candidate page

screen shot 2018-07-16 at 8 27 30 am

New filings page

Information such as documents and image number columns are truncated to fit the mockup, but in production no overlap of graphics and text, or truncation of numbers should occur.
screen shot 2018-07-10 at 11 04 18 am

@lbeaufort
Copy link
Member

@JonellaCulmer could you provide some visuals of what you expect this to look like?

@johnnyporkchops
Copy link
Contributor

@JonellaCulmer , In your first mockup above, it shows a Disbursements tab for Tammy Baldwin for Senate, but on her page on prod it does not show a Disbursements tab and I do not see this as tab being included in the logic for the candidate-single template. Am I missing something, or is this just because its a old mockup or something?
https://www.fec.gov/data/candidate/S2WI00219/

@JonellaCulmer
Copy link
Contributor Author

@johnnyporkchops Good catch, I'll update that mock-up in the description above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants