Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make raising/spending page cycles data-driven #1947

Closed
lbeaufort opened this issue Apr 25, 2018 · 2 comments
Closed

Make raising/spending page cycles data-driven #1947

lbeaufort opened this issue Apr 25, 2018 · 2 comments
Assignees
@apburnes @lbeaufort
Labels
Work: Front-end
Milestone
Sprint 5.5

Comments

@lbeaufort
Copy link
Member

This arises from #1550

The raising/spending pages cycle dropdown is hard-coded. We should make sure the raising/spending pages automatically add future cycles - possibly we could leverage the macros/cycle-select.jinja
@lbeaufort lbeaufort mentioned this issue Apr 25, 2018
Closed
@apburnes
Copy link
Contributor

apburnes commented Apr 26, 2018 •
edited
Loading

We could add utils.get_cycles to each of the views and then use macros/cycle-select in the template.

Ie https://github.com/fecgov/fec-cms/blob/develop/fec/data/views.py#L378-L384

@lbeaufort lbeaufort added this to the Sprint 5.5 milestone Apr 27, 2018
@lbeaufort lbeaufort mentioned this issue Apr 27, 2018
Merged
@AmyKort
Copy link

AmyKort commented May 2, 2018

Merged, so closing.

@AmyKort AmyKort closed this as completed May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apburnes apburnes

@lbeaufort lbeaufort

Labels
Work: Front-end
Projects
None yet
Milestone
Sprint 5.5
Development

No branches or pull requests
3 participants
@apburnes @AmyKort @lbeaufort