Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent expenditure search: difficulty finding Form 5 filers #1900

Closed
Tracked by #113
PaulClark2 opened this issue Apr 3, 2018 · 5 comments
Closed
Tracked by #113

Independent expenditure search: difficulty finding Form 5 filers #1900

PaulClark2 opened this issue Apr 3, 2018 · 5 comments
Assignees
Milestone

Comments

@PaulClark2
Copy link
Contributor

What we’re after:
We need to ensure that all IE filers are available from our search tools.

Current state:
Some Form 5 filers to do appear if a user searches by name but do appear if searching by filer ID.

See for example, America Inc. C90014788

image

Completion criteria:

@PaulClark2 PaulClark2 added the Bug label Apr 3, 2018
@PaulClark2 PaulClark2 added this to the Sprint 5.4 milestone Apr 3, 2018
@lbeaufort
Copy link
Member

lbeaufort commented Apr 4, 2018

Hi @PaulClark2 it looks like because the results are sorted by receipts (and contributions are not often reported by C9 filers), C9 results are more likely to be at the bottom. Results are limited to 20 on the API side, but it looks like the front end is showing top 10.

https://github.com/fecgov/openFEC/blob/develop/webservices/resources/search.py#L48

Also, the search uses the widely implemented full-text filter function (filter_fulltext), which does a fuzzy match, which is why it doesn't appear - there are more than 20 results that fuzzy match "America Inc"

@PaulClark2
Copy link
Contributor Author

Thanks for looking at this. I'm not sure how to move forward on this. So, folks will have problems finding F5, F7 and F9 filers because these filers generally don't include receipts information. I'm not sure how to move forward on this. We need to think of a way for users to find these types of filers.

@lbeaufort
Copy link
Member

lbeaufort commented Apr 5, 2018

One idea that comes to mind is weighting and displaying exact matches higher in the results. If there's a simple implementation it doesn't come to mind, but it could be done. We would want to be mindful of the broad scope of the filter_multitext function and make sure we only impact the /search/ (typeahead) endpoints.

@lbeaufort
Copy link
Member

In sprint planning we decided to sort results by receipts + disbursements

@lbeaufort
Copy link
Member

Issue moved to fecgov/openFEC #3057 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants