Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad IE link on committee summary page #1720

Closed
1 task
Tracked by #113
PaulClark2 opened this issue Jan 28, 2018 · 3 comments
Closed
1 task
Tracked by #113

Bad IE link on committee summary page #1720

PaulClark2 opened this issue Jan 28, 2018 · 3 comments

Comments

@PaulClark2
Copy link
Contributor

PaulClark2 commented Jan 28, 2018

What we are after:
We need to provide users the correct link to IEs from committee summary pages.

Current state:
The link from committee summary pages to IEs 404s. The link is incorrect.

Incorrect link (NOTE: missing /data/)
https://www.fec.gov/independent_expenditures/?committee_id=C00495861&two_year_transaction_period=2018&cycle=2018

Correct link (NOTE: /data/
https://www.fec.gov/data/independent-expenditures/?committee_id=C00495861&two_year_transaction_period=2018&cycle=2018

Completion criteria:

  • update committee page to provide correct IE link

Related issues or PRs:
See https://github.com/18F/FEC/issues/5089

This will need a hotfix.

@lbeaufort lbeaufort added this to the Sprint 5.2 milestone Feb 27, 2018
@AmyKort AmyKort changed the title Bad link on committee summary page Bad IE link on committee summary page Feb 27, 2018
@johnnyporkchops
Copy link
Contributor

johnnyporkchops commented Feb 27, 2018

In addition to missing /data, the /independent_expenditure part of the link should be independent-expenditure (dash instead of underscore)
Also party_coordinated_expenditure should be changed to dashes. These are 404ing to .

@jenniferthibault
Copy link
Contributor

jenniferthibault commented Feb 28, 2018

@johnnyporkchops—a similar issue with this bug pattern was just reported in fecgov/FEC#5452

Flagging that here in case seeing this scenario impacts the approach in the PR you filed.

(The original issue this came from was reported fecgov/FEC#5089 )

@AmyKort
Copy link

AmyKort commented Mar 1, 2018

Merged, so closing. Thanks everybody!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants