Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused "between-committees.jinja" template #1632

Closed
1 task
Tracked by #113
jenniferthibault opened this issue Dec 8, 2017 · 1 comment
Closed
1 task
Tracked by #113

Remove unused "between-committees.jinja" template #1632

jenniferthibault opened this issue Dec 8, 2017 · 1 comment
Assignees

Comments

@jenniferthibault
Copy link
Contributor

Discovered through https://github.com/18F/fec-cms/issues/1605


Between committees used to be a tab under the Committee profile pages, but since the data was self-reported it introduced weirdness that made it seem like it was not accurate enough to display ( fecgov/openFEC-web-app#1448 )

In fecgov/openFEC-web-app#1819 and fecgov/openFEC-web-app#2019 it looks like that information was gathered under the Spending tab to make consistent models across the site, and reconfigured into Disbursement transactions, so we no longer use or need the .jinja template.

If we return to it in the future, we can get it back through GitHub's commit history

Completion criteria:

  • Unused template fec/data/templates/partials/committee/between-committees.jinja is deleted from the repository
@jenniferthibault
Copy link
Contributor Author

Moved to "Done" since it's part of https://github.com/18F/fec-cms/pull/1641 awaiting review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants