Withdrawn AO issue

[patphongs]

It appears that a few withdrawn AOs are not showing up as withdrawn within the Date issued column. These AOs include AO 2017-11 and AO 2009-05.

https://www.fec.gov/data/legal/search/advisory-opinions/?type=advisory_opinions&ao_category=W

• Verify that ao.stage data maps to AO status (0 = pending, 2 = withdrawn, 1 = final)

• Replace AO is_pending with with ao_status

• Verify searches still work in API where ao_category=W

• Test AO search with status parameter

• CMS - change logic for display date for withdrawn AO's to check AO status, not date = 1/1/1900. This was providing unreliable data.

• Test AO 2009-05

• Test AO 2017-11

Thanks @vrajmohan for your help!

[lbeaufort]

Looks like the logic here is the cause: https://github.com/18F/fec-cms/blob/develop/fec/fec/static/js/legal/SearchResults.js#L15

[lbeaufort]

Currently, the AO endpoint has a boolean is_pending parameter, and is searchable for ao_category=W, but it doesn't seem that ao_category is displayed in the output. I think the CMS may need to consume the ao_category data point in order for the display logic to be correct for the "Date Issued" column
here. I'm asking Vraj the best way to address the gaps in the logic above ^^

[lbeaufort]

It looks like in the database, the stage field corresponds with AO status above. However, one withdrawn AO (2009-05) seems to have been marked Final in the internal database. We can capture those outliers by including AO's with "Withdrawn" in the summary: select ao_no, stage, * from aouser.ao where stage=2 OR ao.summary LIKE 'Withdrawn%';

[vrajmohan]

Unless there is diligence over the AO summary, ao.summary LIKE 'Withdrawn%' seems to be a very wide net.

[lbeaufort]

@vrajmohan I agree - I don't like programming around inconsistent data. Maybe a better option would be to explore updating the data on our end so Stage = Withdrawn instead of Final for AO 2009-05

[lbeaufort]

Agreed-upon solution is to hard-code the withdrawn AO that is marked as final in the database until its stage can be changed to withdrawn in the database.

select ao_no, stage, * from aouser.ao where stage=2 OR ao_no='2009-05';