Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate pages are not loading datatables #1329

Closed
Tracked by #118
xtine opened this issue Oct 11, 2017 · 6 comments
Closed
Tracked by #118

Candidate pages are not loading datatables #1329

xtine opened this issue Oct 11, 2017 · 6 comments

Comments

@xtine
Copy link
Contributor

xtine commented Oct 11, 2017

There is a JS bug which prevents loading of datatables on candidate pages. Looks to be possibly a Webpack error, but more investigation is needed to figure out the actual source of the problem. This is a bug produced after webapp+cms merge.

For reference, datatables on similarly styled pages like /data/elections/* to not seem be affected by this so it might be helpful to compare any differences in implementation and compilation of JS.

Might be helpful to look at: https://github.com/webpack/webpack/issues/959

screen shot 2017-10-11 at 9 19 50 am

@patphongs
Copy link
Member

This might be a clue. The code is breaking at line 54. When adding a breakpoint there, I stepped through all the modules that are loaded. One particular moduleId: 111 is undefined. How can we traceback what module is being called here?

screen shot 2017-10-12 at 11 51 42 pm

@johnnyporkchops
Copy link
Contributor

Does this mean anything: Line 11 of /static/js/candidate-single-46ba4a7c0619f64dc25e.js
oct-15-2017 23-54-41

@patphongs
Copy link
Member

@johnnyporkchops Looks like there is a problem finding that particular module var maps = require('../modules/maps');. The pages in which this module is required is on the /fec/fec/static/js/pages/candidate-single.js, /fec/fec/static/js/pages/committee-single.js, and /fec/fec/static/js/pages/elections.js

@patphongs patphongs added this to the Sprint 4.2 milestone Oct 16, 2017
@johnnyporkchops
Copy link
Contributor

Do you think it is a path variable issue somewhere?

@patphongs
Copy link
Member

This should be resolved in the most recent PR here https://github.com/18F/fec-cms/pull/1351

@patphongs
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants