From 17a889359249509b3f6be431880584c543fcc653 Mon Sep 17 00:00:00 2001 From: john carroll Date: Mon, 7 Oct 2019 16:41:04 -0400 Subject: [PATCH 1/2] remove resundent table-row style --- fec/fec/static/scss/components/_table-styles.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/fec/fec/static/scss/components/_table-styles.scss b/fec/fec/static/scss/components/_table-styles.scss index 3c1fbaaf88..2c9c5cda3f 100644 --- a/fec/fec/static/scss/components/_table-styles.scss +++ b/fec/fec/static/scss/components/_table-styles.scss @@ -225,7 +225,6 @@ h3 + .simple-table { .election-dates-table { tr { - display: table-row ; &.row_display { display: table-row; } From 03177c3d0ddd79fb430dec7968b92cb3af57fc85 Mon Sep 17 00:00:00 2001 From: john carroll Date: Mon, 7 Oct 2019 17:03:52 -0400 Subject: [PATCH 2/2] remove unused comments tweak SCSS --- .../static/scss/components/_table-styles.scss | 25 ++++++++----------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/fec/fec/static/scss/components/_table-styles.scss b/fec/fec/static/scss/components/_table-styles.scss index 2c9c5cda3f..e6ce59d286 100644 --- a/fec/fec/static/scss/components/_table-styles.scss +++ b/fec/fec/static/scss/components/_table-styles.scss @@ -202,11 +202,11 @@ h3 + .simple-table { border: 1px solid $gray-light; &:first-child { - border-left:none; + border-left: none; } &:last-child { - border-right:none; + border-right: none; } } @@ -232,7 +232,7 @@ h3 + .simple-table { td { .th_append { - display:none !important; + display: none !important; } } @@ -261,21 +261,19 @@ h3 + .simple-table { } tr.footnote_row { - /*background: $inverse !important;*/ td { - /*background: $inverse !important;*/ border:none !important; padding-bottom: u(1rem); &:first-child { border-right: 1px solid $gray-light !important; } a { - border-bottom:1px dotted $gray-dark; + border-bottom: 1px dotted $gray-dark; } span { line-height: u(1.5rem); - font-weight:bold; + font-weight: bold; } } } @@ -293,10 +291,6 @@ h3 + .simple-table { } - th { - /*visibility:collapse;*/ - } - /* Hide table headers (but not display: none;, for accessibility) */ thead tr { position: absolute; @@ -312,10 +306,13 @@ h3 + .simple-table { display: block !important; } &.footnote_row { - display:none !important; + display: none !important; } + /* Hide table headers (but not display: none;, for accessibility) */ &:first-child{ - display: none !important; + position: absolute; + top: -9999px; + left: -9999px; } } @@ -339,7 +336,7 @@ h3 + .simple-table { tr:nth-child(even) td { - border-bottom:1px solid #aaa + border-bottom: 1px solid #aaa } .ftnt_append {